Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()

kbuild test robot
2019-10-15T03:59:46Z

[-- Attachment #1: Type: text/plain, Size: 3234 bytes --]

Hi Dmitry,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc3 next-20191014]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/drm-bridge-ti-tfp410-switch-to-using-fwnode_gpiod_get_index/20191015-024641
config: nds32-allmodconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=nds32

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/gpu/drm/bridge/ti-tfp410.c: In function 'tfp410_get_connector_properties':
drivers/gpu/drm/bridge/ti-tfp410.c:287:13: error: implicit declaration of function 'fwnode_gpiod_get_index'; did you mean 'devm_gpiod_get_index'? [-Werror=implicit-function-declaration]
dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
^~~~~~~~~~~~~~~~~~~~~~
devm_gpiod_get_index
>> drivers/gpu/drm/bridge/ti-tfp410.c:287:11: warning: assignment to 'struct gpio_desc *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
^
cc1: some warnings being treated as errors

vim +287 drivers/gpu/drm/bridge/ti-tfp410.c

271
272 static int tfp410_get_connector_properties(struct tfp410 *dvi)
273 {
274 struct device_node *connector_node, *ddc_phandle;
275 int ret = 0;
276
277 /* port@1 is the connector node */
278 connector_node = of_graph_get_remote_node(dvi->dev->of_node, 1, -1);
279 if (!connector_node)
280 return -ENODEV;
281
282 if (of_device_is_compatible(connector_node, "hdmi-connector"))
283 dvi->connector_type = DRM_MODE_CONNECTOR_HDMIA;
284 else
285 dvi->connector_type = DRM_MODE_CONNECTOR_DVID;
286
> 287 dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
288 "hpd", 0, GPIOD_IN, "hpd");
289 if (IS_ERR(dvi->hpd)) {
290 ret = PTR_ERR(dvi->hpd);
291 dvi->hpd = NULL;
292 if (ret == -ENOENT)
293 ret = 0;
294 else
295 goto fail;
296 }
297
298 ddc_phandle = of_parse_phandle(connector_node, "ddc-i2c-bus", 0);
299 if (!ddc_phandle)
300 goto fail;
301
302 dvi->ddc = of_get_i2c_adapter_by_node(ddc_phandle);
303 if (dvi->ddc)
304 dev_info(dvi->dev, "Connector's ddc i2c bus found\n");
305 else
306 ret = -EPROBE_DEFER;
307
308 of_node_put(ddc_phandle);
309
310 fail:
311 of_node_put(connector_node);
312 return ret;
313 }
314

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52991 bytes --]