Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index()

Dmitry Torokhov
2019-11-05T00:40:56Z

On Mon, Oct 14, 2019 at 11:43:20AM -0700, Dmitry Torokhov wrote:
> Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use
> the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but
> works with arbitrary firmware node.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> Andrzej, Neil,
>
> This depends on the new code that can be bound in
> ib-fwnode-gpiod-get-index immutable branch of Linus' Walleij tree:
>
> git pull git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git ib-fwnode-gpiod-get-index
>
> I hope that it would be possible to pull in this immutable branch and
> not wait until after 5.5 merge window, or, alternatively, merge through
> Linus Walleij's tree.

Any chance this could be merged, please?

>
> Thanks!
>
> drivers/gpu/drm/bridge/ti-tfp410.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c
> index aa3198dc9903..6f6d6d1e60ae 100644
> --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> @@ -285,8 +285,8 @@ static int tfp410_get_connector_properties(struct tfp410 *dvi)
> else
> dvi->connector_type = DRM_MODE_CONNECTOR_DVID;
>
> - dvi->hpd = fwnode_get_named_gpiod(&connector_node->fwnode,
> - "hpd-gpios", 0, GPIOD_IN, "hpd");
> + dvi->hpd = fwnode_gpiod_get_index(&connector_node->fwnode,
> + "hpd", 0, GPIOD_IN, "hpd");
> if (IS_ERR(dvi->hpd)) {
> ret = PTR_ERR(dvi->hpd);
> dvi->hpd = NULL;
> --
> 2.23.0.700.g56cf767bdb-goog
>
>
> --
> Dmitry

--
Dmitry