From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chen Wandun <chenwandun@huawei.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
perex@perex.cz, gregkh@linuxfoundation.org,
kstewart@linuxfoundation.org, allison@lohutok.net,
tglx@linutronix.de, joe@perches.com
Subject: Re: [PATCH v2] hp100: remove set but not used variable val
Date: Tue, 5 Nov 2019 17:43:29 +0300 [thread overview]
Message-ID: <20191105144329.GG10409@kadam> (raw)
In-Reply-To: <1572964619-76671-1-git-send-email-chenwandun@huawei.com>
On Tue, Nov 05, 2019 at 10:36:59PM +0800, Chen Wandun wrote:
> From: Chenwandun <chenwandun@huawei.com>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/staging/hp/hp100.c: In function hp100_start_xmit:
> drivers/staging/hp/hp100.c:1629:10: warning: variable val set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Chenwandun <chenwandun@huawei.com>
> ---
You should explain why you are sending a v2 under the --- cut off line.
The v1 was the correct patch, but this driver is going to be deleted
soon so I don't think we are accepting this sort of cleanup.
regards,
dan carpenter
next prev parent reply other threads:[~2019-11-05 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191105133554.6C01F9A06CB85816F399@huawei.com>
2019-11-05 14:36 ` [PATCH v2] hp100: remove set but not used variable val Chen Wandun
2019-11-05 14:43 ` Dan Carpenter [this message]
2019-11-05 15:50 ` Greg KH
2019-11-05 17:13 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105144329.GG10409@kadam \
--to=dan.carpenter@oracle.com \
--cc=allison@lohutok.net \
--cc=chenwandun@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox