From: Christoph Hellwig <hch@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-spdx@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: spdxcheck.py complains about the second OR?
Date: Tue, 5 Nov 2019 07:47:54 -0800 [thread overview]
Message-ID: <20191105154754.GA18119@infradead.org> (raw)
In-Reply-To: <46615f063c973eee649e3fdb8261978102c89108.camel@perches.com>
On Mon, Nov 04, 2019 at 02:24:23PM -0800, Joe Perches wrote:
> On Mon, 2019-11-04 at 23:11 +0100, Thomas Gleixner wrote:
> > On Fri, 1 Nov 2019, Masahiro Yamada wrote:
> > > scripts/spdxcheck.py warns the following two files.
> > >
> > > $ ./scripts/spdxcheck.py
> > > drivers/net/ethernet/pensando/ionic/ionic_if.h: 1:52 Syntax error: OR
> > > drivers/net/ethernet/pensando/ionic/ionic_regs.h: 1:52 Syntax error: OR
> > >
> > > I do not understand what is wrong with them.
> > >
> > > I think "A OR B OR C" is sane.
> >
> > Yes it is, but obviously we did not expect files with 3 possible
> > alternative licenses.
>
> Perhaps just this, but the generic logic
> obviously isn't complete.
Can we please print a warning in that case even if we end up parsing
it correct? tripple licensing always has a bit of a bad smell.
next prev parent reply other threads:[~2019-11-05 15:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 4:25 spdxcheck.py complains about the second OR? Masahiro Yamada
2019-11-04 22:11 ` Thomas Gleixner
2019-11-04 22:24 ` Joe Perches
2019-11-05 10:11 ` Zavras, Alexios
2019-11-05 15:10 ` Joe Perches
2019-11-11 9:37 ` Zavras, Alexios
2019-11-05 15:47 ` Christoph Hellwig [this message]
2019-11-04 23:53 ` Christoph Hellwig
[not found] ` <CAG_66ZQ3f39bv=0Yw=Eum0vcxbf94mmXE9jdJUpi6+gEEqkS8A@mail.gmail.com>
2019-11-05 14:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105154754.GA18119@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spdx@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox