From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, rui.zhang@intel.com,
edubezval@gmail.com, qperret@google.com,
linux-kernel@vger.kernel.org, amit.kachhap@gmail.com,
javi.merino@kernel.org, daniel.lezcano@linaro.org
Subject: Re: [Patch v5 2/6] sched/fair: Add infrastructure to store and update instantaneous thermal pressure
Date: Tue, 5 Nov 2019 20:21:54 +0000 [thread overview]
Message-ID: <20191105202037.GA17494@e108754-lin> (raw)
In-Reply-To: <1572979786-20361-3-git-send-email-thara.gopinath@linaro.org>
Hi Thara,
On Tuesday 05 Nov 2019 at 13:49:42 (-0500), Thara Gopinath wrote:
[...]
> +static void trigger_thermal_pressure_average(struct rq *rq)
> +{
> +#ifdef CONFIG_SMP
> + update_thermal_load_avg(rq_clock_task(rq), rq,
> + per_cpu(thermal_pressure, cpu_of(rq)));
> +#endif
> +}
Why did you decide to keep trigger_thermal_pressure_average and not
call update_thermal_load_avg directly?
For !CONFIG_SMP you already have an update_thermal_load_avg function
that does nothing, in kernel/sched/pelt.h, so you don't need that
ifdef.
Thanks,
Ionela.
> +
> /*
> * All the scheduling class methods:
> */
> --
> 2.1.4
>
next prev parent reply other threads:[~2019-11-05 20:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 18:49 [Patch v5 0/6] Introduce Thermal Pressure Thara Gopinath
2019-11-05 18:49 ` [Patch v5 1/6] sched/pelt.c: Add support to track thermal pressure Thara Gopinath
2019-11-06 8:24 ` Vincent Guittot
2019-11-06 12:50 ` Dietmar Eggemann
2019-11-06 17:00 ` Thara Gopinath
2019-11-07 16:39 ` Qais Yousef
2019-11-19 10:50 ` Amit Kucheria
2019-11-05 18:49 ` [Patch v5 2/6] sched/fair: Add infrastructure to store and update instantaneous " Thara Gopinath
2019-11-05 20:21 ` Ionela Voinescu [this message]
2019-11-05 21:02 ` Thara Gopinath
2019-11-05 21:15 ` Ionela Voinescu
2019-11-05 21:29 ` Thara Gopinath
2019-11-05 21:53 ` Ionela Voinescu
2019-11-06 12:50 ` Dietmar Eggemann
2019-11-06 17:53 ` Thara Gopinath
2019-11-07 9:32 ` Dietmar Eggemann
2019-11-07 10:48 ` Vincent Guittot
2019-11-07 11:36 ` Dietmar Eggemann
2019-11-06 8:27 ` Vincent Guittot
2019-11-06 17:00 ` Thara Gopinath
2019-11-19 10:51 ` Amit Kucheria
2019-11-05 18:49 ` [Patch v5 3/6] sched/fair: Enable periodic update of average " Thara Gopinath
2019-11-06 8:32 ` Vincent Guittot
2019-11-06 17:01 ` Thara Gopinath
2019-11-05 18:49 ` [Patch v5 4/6] sched/fair: update cpu_capcity to reflect " Thara Gopinath
2019-11-06 16:56 ` Qais Yousef
2019-11-06 17:31 ` Thara Gopinath
2019-11-06 17:41 ` Qais Yousef
2019-11-19 10:51 ` Amit Kucheria
2019-11-05 18:49 ` [Patch v5 5/6] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2019-11-06 12:50 ` Dietmar Eggemann
2019-11-06 17:28 ` Thara Gopinath
2019-11-07 13:00 ` Dietmar Eggemann
2019-11-05 18:49 ` [Patch v5 6/6] sched/fair: Enable tuning of decay period Thara Gopinath
2019-11-07 10:49 ` Vincent Guittot
2019-11-08 10:53 ` Dietmar Eggemann
2019-11-19 10:52 ` Amit Kucheria
2019-11-12 11:21 ` [Patch v5 0/6] Introduce Thermal Pressure Lukasz Luba
2019-11-19 15:12 ` Lukasz Luba
2019-11-19 10:54 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105202037.GA17494@e108754-lin \
--to=ionela.voinescu@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox