From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2994BC5DF60 for ; Tue, 5 Nov 2019 21:15:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E53A521882 for ; Tue, 5 Nov 2019 21:15:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729959AbfKEVP0 (ORCPT ); Tue, 5 Nov 2019 16:15:26 -0500 Received: from foss.arm.com ([217.140.110.172]:53974 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729747AbfKEVP0 (ORCPT ); Tue, 5 Nov 2019 16:15:26 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1039830E; Tue, 5 Nov 2019 13:15:26 -0800 (PST) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.199.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A50563F6C4; Tue, 5 Nov 2019 13:15:25 -0800 (PST) Date: Tue, 5 Nov 2019 21:15:24 +0000 From: Ionela Voinescu To: Thara Gopinath Cc: mingo@redhat.com, peterz@infradead.org, vincent.guittot@linaro.org, rui.zhang@intel.com, edubezval@gmail.com, qperret@google.com, linux-kernel@vger.kernel.org, amit.kachhap@gmail.com, javi.merino@kernel.org, daniel.lezcano@linaro.org Subject: Re: [Patch v5 2/6] sched/fair: Add infrastructure to store and update instantaneous thermal pressure Message-ID: <20191105211446.GA25349@e108754-lin> References: <1572979786-20361-1-git-send-email-thara.gopinath@linaro.org> <1572979786-20361-3-git-send-email-thara.gopinath@linaro.org> <20191105202037.GA17494@e108754-lin> <5DC1E348.2090104@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5DC1E348.2090104@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 05 Nov 2019 at 16:02:00 (-0500), Thara Gopinath wrote: > On 11/05/2019 03:21 PM, Ionela Voinescu wrote: > > Hi Thara, > > > > On Tuesday 05 Nov 2019 at 13:49:42 (-0500), Thara Gopinath wrote: > > [...] > >> +static void trigger_thermal_pressure_average(struct rq *rq) > >> +{ > >> +#ifdef CONFIG_SMP > >> + update_thermal_load_avg(rq_clock_task(rq), rq, > >> + per_cpu(thermal_pressure, cpu_of(rq))); > >> +#endif > >> +} > > > > Why did you decide to keep trigger_thermal_pressure_average and not > > call update_thermal_load_avg directly? > > > > For !CONFIG_SMP you already have an update_thermal_load_avg function > > that does nothing, in kernel/sched/pelt.h, so you don't need that > > ifdef. > Hi, > > Yes you are right. But later with the shift option added, I shift > rq_clock_task(rq) by the shift. I thought it is better to contain it in > a function that replicate it in three different places. I can remove the > CONFIG_SMP in the next version. You could still keep that in one place if you shift the now argument of ___update_load_sum instead. To me that trigger_thermal_pressure_average function seems more code than it's worth for this. Thanks, Ionela. > > > > Thanks, > > Ionela. > > > >> + > >> /* > >> * All the scheduling class methods: > >> */ > >> -- > >> 2.1.4 > >> > > > -- > Warm Regards > Thara