Re: [Patch v4 2/6] sched: Add infrastructure to store and update instantaneous thermal pressure

Thara Gopinath
2019-11-01T20:58:04Z

On 11/01/2019 08:17 AM, Dietmar Eggemann wrote:
> On 22.10.19 22:34, Thara Gopinath wrote:
>
> [...]
>
>> +/**
>> + * trigger_thermal_pressure_average: Trigger the thermal pressure accumulate
>> + * and average algorithm
>> + */
>> +void trigger_thermal_pressure_average(struct rq *rq)
>> +{
>> + update_thermal_load_avg(rq_clock_task(rq), rq,
>> + per_cpu(delta_capacity, cpu_of(rq)));
>> +}
>
> Why not call update_thermal_load_avg() directly in fair.c? We do this for all
> the other update_foo_load_avg() functions (foo eq. irq, rt_rq, dl_rq ...)
thermal.c is going away in next version and I am moving everything to
fair.c. So this is taken care of

>
> You don't have to pass 'u64 now', so you can hide it plus the

You still need now.All the update_*_avg apis take now as a parameter.

--
Warm Regards
Thara