public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Safonov <dima@arista.com>
To: linux-kernel@vger.kernel.org
Cc: Dmitry Safonov <0x7f454c46@gmail.com>,
	Dmitry Safonov <dima@arista.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jslaby@suse.com>,
	Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	Jason Wessel <jason.wessel@windriver.com>,
	kgdb-bugreport@lists.sourceforge.net
Subject: [PATCH 47/50] kdb: Don't play with console_loglevel
Date: Wed,  6 Nov 2019 03:05:38 +0000	[thread overview]
Message-ID: <20191106030542.868541-48-dima@arista.com> (raw)
In-Reply-To: <20191106030542.868541-1-dima@arista.com>

Print the stack trace with KERN_EMERG - it should be always visible.

Playing with console_loglevel is a bad idea as there may be more
messages printed than wanted. Also the stack trace might be not printed
at all if printk() was deferred and console_loglevel was raised back
before the trace got flushed.

Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: kgdb-bugreport@lists.sourceforge.net
Signed-off-by: Dmitry Safonov <dima@arista.com>
---
 kernel/debug/kdb/kdb_bt.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/kernel/debug/kdb/kdb_bt.c b/kernel/debug/kdb/kdb_bt.c
index 7e2379aa0a1e..5ce1fe082a38 100644
--- a/kernel/debug/kdb/kdb_bt.c
+++ b/kernel/debug/kdb/kdb_bt.c
@@ -21,22 +21,19 @@
 
 static void kdb_show_stack(struct task_struct *p, void *addr)
 {
-	int old_lvl = console_loglevel;
-	console_loglevel = CONSOLE_LOGLEVEL_MOTORMOUTH;
 	kdb_trap_printk++;
 	kdb_set_current_task(p);
 	if (addr) {
-		show_stack((struct task_struct *)p, addr);
+		show_stack_loglvl(p, addr, KERN_EMERG);
 	} else if (kdb_current_regs) {
 #ifdef CONFIG_X86
-		show_stack(p, &kdb_current_regs->sp);
+		show_stack_loglvl(p, &kdb_current_regs->sp, KERN_EMERG);
 #else
-		show_stack(p, NULL);
+		show_stack_loglvl(p, NULL, KERN_EMERG);
 #endif
 	} else {
-		show_stack(p, NULL);
+		show_stack_loglvl(p, NULL, KERN_EMERG);
 	}
-	console_loglevel = old_lvl;
 	kdb_trap_printk--;
 }
 
-- 
2.23.0


  parent reply	other threads:[~2019-11-06  3:09 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191106030542.868541-1-dima@arista.com>
2019-11-06  3:04 ` [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() Dmitry Safonov
2019-11-06  4:38   ` Sergey Senozhatsky
2019-11-06 16:39     ` Dmitry Safonov
2019-11-13 15:49   ` Steven Rostedt
2019-11-06  3:04 ` [PATCH 02/50] alpha: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:04 ` [PATCH 03/50] arc: " Dmitry Safonov
2019-11-06  3:04 ` [PATCH 04/50] arm/asm: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06  3:04 ` [PATCH 05/50] arm: Add loglvl to unwind_backtrace() Dmitry Safonov
2019-11-06  9:12   ` Russell King - ARM Linux admin
2019-11-06 16:32     ` Dmitry Safonov
2019-11-06  3:04 ` [PATCH 06/50] arm: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06  3:04 ` [PATCH 07/50] arm: Wire up dump_backtrace_{entry,stm} Dmitry Safonov
2019-11-06  3:04 ` [PATCH 08/50] arm: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 09/50] arm64: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06 13:25   ` Will Deacon
2019-11-06 16:00     ` Dmitry Safonov
2019-11-06  3:05 ` [PATCH 10/50] arm64: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 11/50] c6x: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 12/50] csky: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 13/50] h8300: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 14/50] hexagon: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 15/50] ia64: Pass log level as arg into ia64_do_show_stack() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 16/50] ia64: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 17/50] m68k: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 18/50] microblaze: Add loglvl to microblaze_unwind_inner() Dmitry Safonov
2019-11-07  8:59   ` Michal Simek
2019-11-08  7:52   ` kbuild test robot
2019-11-06  3:05 ` [PATCH 19/50] microblaze: Add loglvl to microblaze_unwind() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 20/50] microblaze: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 21/50] mips: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 22/50] nds32: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 23/50] nios2: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 24/50] openrisc: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 25/50] parisc: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 26/50] powerpc: " Dmitry Safonov
2019-11-06  9:52   ` Michael Ellerman
2019-11-06 16:01     ` Dmitry Safonov
2019-11-06  3:05 ` [PATCH 27/50] riscv: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 28/50] s390: " Dmitry Safonov
2019-11-06  3:05 ` [PATCH 29/50] sh: Add loglvl to dump_mem() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 30/50] sh: Remove needless printk() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 31/50] sh: Add loglvl to printk_address() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 32/50] sh: Add loglvl to show_trace() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 33/50] sh: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 34/50] sparc: " Dmitry Safonov
2019-11-06  3:33   ` David Miller
2019-11-06 16:02     ` Dmitry Safonov
2019-11-08  7:08   ` kbuild test robot
2019-11-06  3:05 ` [PATCH 35/50] um/sysrq: Remove needless variable sp Dmitry Safonov
2019-11-06  3:05 ` [PATCH 36/50] um: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 37/50] unicore32: Remove unused pmode argument in c_backtrace() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 38/50] unicore32: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 39/50] unicore32: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 40/50] x86: Add missing const qualifiers for log_lvl Dmitry Safonov
2019-11-06  3:05 ` [PATCH 41/50] x86: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 42/50] xtensa: Add loglvl to show_trace() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 43/50] xtensa: Add show_stack_loglvl() Dmitry Safonov
2019-11-06  4:13   ` Max Filippov
2019-11-06  8:15     ` Petr Mladek
2019-11-06 16:06       ` Dmitry Safonov
2019-11-06 16:44       ` Max Filippov
2019-11-06  3:05 ` [PATCH 44/50] sysrq: Use show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 45/50] x86/amd_gart: Print stacktrace for a leak with KERN_ERR Dmitry Safonov
2019-11-06  3:05 ` [PATCH 46/50] power: Use show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` Dmitry Safonov [this message]
2019-11-06  3:05 ` [PATCH 48/50] sched: Print stack trace with KERN_INFO Dmitry Safonov
2019-11-06  3:05 ` [PATCH 49/50] kernel: Use show_stack_loglvl() Dmitry Safonov
2019-11-06  3:05 ` [PATCH 50/50] kernel: Rename show_stack_loglvl() => show_stack() Dmitry Safonov
2019-11-08 10:08   ` kbuild test robot
     [not found] ` <20191106092039.GT4131@hirez.programming.kicks-ass.net>
     [not found]   ` <10db6fa1-5b17-ebe6-09e0-6335e09e4db8@arista.com>
     [not found]     ` <20191106203440.GH3079@worktop.programming.kicks-ass.net>
     [not found]       ` <20191106232512.GU25745@shell.armlinux.org.uk>
2019-11-07  7:27         ` [PATCH 00/50] Add log level to show_stack() Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106030542.868541-48-dima@arista.com \
    --to=dima@arista.com \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason.wessel@windriver.com \
    --cc=jslaby@suse.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox