From: Peter Zijlstra <peterz@infradead.org>
To: Ganapatrao Prabhakerrao Kulkarni <gkulkarni@marvell.com>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"will@kernel.org" <will@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"gklkml16@gmail.com" <gklkml16@gmail.com>
Subject: Re: [PATCH 1/2] perf/core: Adding capability to disable PMUs event multiplexing
Date: Wed, 6 Nov 2019 10:58:10 +0100 [thread overview]
Message-ID: <20191106095810.GK5671@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191106094032.GV4131@hirez.programming.kicks-ass.net>
On Wed, Nov 06, 2019 at 10:40:32AM +0100, Peter Zijlstra wrote:
> On Wed, Nov 06, 2019 at 01:01:40AM +0000, Ganapatrao Prabhakerrao Kulkarni wrote:
> > When PMUs are registered, perf core enables event multiplexing
> > support by default. There is no provision for PMUs to disable
> > event multiplexing, if PMUs want to disable due to unavoidable
> > circumstances like hardware errata etc.
> >
> > Adding PMU capability flag PERF_PMU_CAP_NO_MUX_EVENTS and support
> > to allow PMUs to explicitly disable event multiplexing.
>
> This doesn't make sense, multiplexing relies on nothing that normal
> event scheduling doesn't also rely on.
>
> Either you can schedule different sets of events, or you cannot.
More specifically, how is a reschedule due to rotation any different
than a reschedule due to context switch?
Both cases we do a full reprogram of the PMU.
next prev parent reply other threads:[~2019-11-06 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 1:01 [PATCH 0/2] Workaround for ThunderX2 erratum 221 Ganapatrao Prabhakerrao Kulkarni
2019-11-06 1:01 ` [PATCH 1/2] perf/core: Adding capability to disable PMUs event multiplexing Ganapatrao Prabhakerrao Kulkarni
2019-11-06 9:40 ` Peter Zijlstra
2019-11-06 9:58 ` Peter Zijlstra [this message]
2019-11-06 11:28 ` Mark Rutland
2019-11-06 23:28 ` Ganapatrao Kulkarni
2019-11-07 14:35 ` Ganapatrao Kulkarni
2019-11-07 14:52 ` Mark Rutland
2019-11-07 15:45 ` Ganapatrao Kulkarni
2019-11-07 15:54 ` Mark Rutland
2019-11-07 15:04 ` Peter Zijlstra
2019-11-07 23:17 ` kbuild test robot
2019-11-06 1:01 ` [PATCH 2/2] Thunderx2, uncore: Add workaround for ThunderX2 erratum 221 Ganapatrao Prabhakerrao Kulkarni
2019-11-06 11:37 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106095810.GK5671@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=corbet@lwn.net \
--cc=gklkml16@gmail.com \
--cc=gkulkarni@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox