Re: [PATCH v5 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

Maxime Ripard
2019-11-05T10:43:48Z

[-- Attachment #1: Type: text/plain, Size: 2687 bytes --]

On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote:
> The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
> for portable devices.
>
> Add a binding document for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Torsten Duwe <duwe@suse.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Applied, thanks

(still, there's one comment below that can be addressed in a
subsequent patch).

> ---
> .../bindings/display/bridge/anx6345.yaml | 102 ++++++++++++++++++++++
> 1 file changed, 102 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/anx6345.yaml b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml
> new file mode 100644
> index 000000000000..094e8e8a5faa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml
> @@ -0,0 +1,102 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/anx6345.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analogix ANX6345 eDP Transmitter Device Tree Bindings
> +
> +maintainers:
> + - Torsten Duwe <duwe@lst.de>
> +
> +description: |
> + The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for
> + portable devices.
> +
> +properties:
> + compatible:
> + const: analogix,anx6345
> +
> + reg:
> + maxItems: 1
> + description: base I2C address of the device
> +
> + reset-gpios:
> + maxItems: 1
> + description: GPIO connected to active low reset
> +
> + dvdd12-supply:
> + maxItems: 1
> + description: Regulator for 1.2V digital core power.
> +
> + dvdd25-supply:
> + maxItems: 1
> + description: Regulator for 2.5V digital core power.
> +
> + ports:
> + type: object
> +
> + properties:
> + port@0:
> + type: object
> + description: |
> + Video port for LVTTL input
> +
> + port@1:
> + type: object
> + description: |
> + Video port for eDP output (panel or connector).
> + May be omitted if EDID works reliably.
> +
> + required:
> + - port@0

You should have something like:

ports:
type: object
additionalProperties: false

as well...

> +
> +required:
> + - compatible
> + - reg
> + - reset-gpios
> + - dvdd12-supply
> + - dvdd25-supply
> + - ports
> +
> +additionalProperties: false

This prevents additional properties only on the top-level node, not
its children.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]