Re: [PATCH v5 2/7] drm/bridge: split some definitions of ANX78xx to dedicated headers

Maxime Ripard
2019-11-06T15:21:47Z

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

Hi

On Tue, Nov 05, 2019 at 06:33:32PM +0100, Torsten Duwe wrote:
> From: Icenowy Zheng <icenowy@aosc.io>
>
> Some definitions currently in analogix-anx78xx.h are not restricted to
> the ANX78xx series, but also applicable to other DisplayPort
> transmitters by Analogix.
>
> Split out them to dedicated headers, and make analogix-anx78xx.h include
> them.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> Signed-off-by: Torsten Duwe <duwe@suse.de>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>
> ---
>
> On Tue, Nov 05, 2019 at 11:41:26AM +0100, Maxime Ripard wrote:
> >
> > This one doesn't apply on drm-misc-next. The fix doesn't look really
> > obvious to me, can you rebase and resend it?
>
> Sure.
> The set was based on 5.4-rc5, which lacks 025910db8057f from drm-misc-next
> You'll also have to
> diff -r anx6345-v5/v5-0005-drm-bridge-Add-Analogix-anx6345-support.patch anx6345-v5a/v5-0005-drm-bridge-Add-Analogix-anx6345-support.patch
> 116,117c116,117
> < + [I2C_IDX_DPTX] = ANALOGIX_I2C_DPTX,
> < + [I2C_IDX_TXCOM] = ANALOGIX_I2C_TXCOMMON,
> ---
> > + [I2C_IDX_DPTX] = 0x70,
> > + [I2C_IDX_TXCOM] = 0x72,
>
> To make it compile, with the changed coding style of 025910db8057f.
> Can you change that on the fly in 5/7 or shall I resend that, too?

Please resend the whole series rebased on top of either linux-next or
drm-misc-next.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]