Re: [PATCH v5 6/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding

Torsten Duwe
2019-11-05T10:58:14Z

On Tue, Nov 05, 2019 at 11:43:42AM +0100, Maxime Ripard wrote:
>
> On Tue, Oct 29, 2019 at 01:16:57PM +0100, Torsten Duwe wrote:
> > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed
> > for portable devices.
> >
> > Add a binding document for it.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Torsten Duwe <duwe@suse.de>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Applied, thanks

Re-thanks!

> (still, there's one comment below that can be addressed in a
> subsequent patch).
>
> > +
> > + ports:
> > + type: object
> > +
> > + properties:
> > + port@0:
> > + type: object
> > + description: |
> > + Video port for LVTTL input
> > +
> > + port@1:
> > + type: object
> > + description: |
> > + Video port for eDP output (panel or connector).
> > + May be omitted if EDID works reliably.
> > +
> > + required:
> > + - port@0
>
> You should have something like:
>
> ports:
> type: object
> additionalProperties: false
>
> as well...

Yes, and it also struck me that I forgot at least about the hotplug-gpio.
It's unused on the Teres and the Pinebook, but in theory it's a valid
property, which can't be added any more now.

Torsten