From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v4 5/9] perf stat: Use affinity for closing file descriptors
Date: Wed, 6 Nov 2019 17:33:50 +0100 [thread overview]
Message-ID: <20191106163350.GL30214@krava> (raw)
In-Reply-To: <20191105002522.83803-6-andi@firstfloor.org>
On Mon, Nov 04, 2019 at 04:25:18PM -0800, Andi Kleen wrote:
SNIP
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index dccf96e0d01b..8f3bfbe277b5 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -18,6 +18,7 @@
> #include "debug.h"
> #include "units.h"
> #include <internal/lib.h> // page_size
> +#include "affinity.h"
> #include "../perf.h"
> #include "asm/bug.h"
> #include "bpf-event.h"
> @@ -1165,9 +1166,33 @@ void perf_evlist__set_selected(struct evlist *evlist,
> void evlist__close(struct evlist *evlist)
> {
> struct evsel *evsel;
> + struct affinity affinity;
> + int cpu, i;
>
> - evlist__for_each_entry_reverse(evlist, evsel)
> - evsel__close(evsel);
> + if (!evlist->core.cpus) {
> + evlist__for_each_entry_reverse(evlist, evsel)
> + evsel__close(evsel);
> + return;
> + }
> +
> + if (affinity__setup(&affinity) < 0)
> + return;
> + evlist__cpu_iter_start(evlist);
> + evlist__for_each_cpu (evlist, i, cpu) {
> + affinity__set(&affinity, cpu);
> +
> + evlist__for_each_entry_reverse(evlist, evsel) {
> + if (evlist__cpu_iter_skip(evsel, cpu))
> + continue;
> + perf_evsel__close_cpu(&evsel->core, evsel->cpu_index);
> + evlist__cpu_iter_next(evsel);
> + }
> + }
looks much better, how about we make it even more compact
from above patern, like:
affinity__setup
evlist__cpu_iter(evlist, i, cpu) {
affinity__set(&affinity, cpu);
evlist__for_each_entry_reverse(evlist, evsel) {
if (evsel__cpu_iter_skip(evsel, cpu))
continue;
perf_evsel__close_cpu(&evsel->core, evsel->cpu_iter);
}
}
affinity__cleanup
where:
- evlist__cpu_iter would call evlist__cpu_iter_start
- evlist__cpu_iter_skip could increment evsel->cpu_index in false case
so there's no need to have evlist__cpu_iter_next
- rename evsel->cpu_index to evsel->cpu_iter
- renamse evlist__cpu_iter_skip to evsel__cpu_iter_skip
jirka
next prev parent reply other threads:[~2019-11-06 16:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 0:25 Optimize perf stat for large number of events/cpus Andi Kleen
2019-11-05 0:25 ` [PATCH v4 1/9] perf pmu: Use file system cache to optimize sysfs access Andi Kleen
2019-11-05 0:25 ` [PATCH v4 2/9] perf affinity: Add infrastructure to save/restore affinity Andi Kleen
2019-11-05 0:25 ` [PATCH v4 3/9] perf evlist: Maintain evlist->all_cpus Andi Kleen
2019-11-06 16:34 ` Jiri Olsa
2019-11-05 0:25 ` [PATCH v4 4/9] perf evsel: Add iterator to iterate over events ordered by CPU Andi Kleen
2019-11-05 0:25 ` [PATCH v4 5/9] perf stat: Use affinity for closing file descriptors Andi Kleen
2019-11-06 16:33 ` Jiri Olsa [this message]
2019-11-06 16:34 ` Jiri Olsa
2019-11-05 0:25 ` [PATCH v4 6/9] perf stat: Factor out open error handling Andi Kleen
2019-11-06 16:33 ` Jiri Olsa
2019-11-05 0:25 ` [PATCH v4 7/9] perf stat: Use affinity for opening events Andi Kleen
2019-11-06 16:34 ` Jiri Olsa
2019-11-05 0:25 ` [PATCH v4 8/9] perf stat: Use affinity for reading Andi Kleen
2019-11-05 0:25 ` [PATCH v4 9/9] perf stat: Use affinity for enabling/disabling events Andi Kleen
2019-11-06 16:34 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106163350.GL30214@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox