From: Mohammad Nasirifar <far.nasiri.m@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Mohammad Nasirifar <farnasirim@gmail.com>,
Linux API <linux-api@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Valdis Kletnieks <valdis.kletnieks@vt.edu>
Subject: Re: [PATCH 1/1] syscalls: Fix references to filenames containing syscall defs
Date: Wed, 6 Nov 2019 11:47:56 -0500 [thread overview]
Message-ID: <20191106164756.GA558585@gmail.com> (raw)
In-Reply-To: <CAK8P3a0wyw=CwhiU34t1zBiSesf+HGBLeaV+=JVko_TjnvATHQ@mail.gmail.com>
On Tue, Nov 05, 2019 at 10:49:12AM +0100, Arnd Bergmann wrote:
>On Tue, Nov 5, 2019 at 10:34 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>> On Mon, 4 Nov 2019, Mohammad Nasirifar wrote:
>> > Fix stale references to files containing syscall definitions in
>> > 'include/linux/syscalls.h' and 'include/uapi/asm-generic/unistd.h',
>> > pointing to 'kernel/itimer.c', 'kernel/hrtimer.c', and 'kernel/time.c'.
>> > They are now under 'kernel/time'.
>> >
>> > Also definitions of 'getpid', 'getppid', 'getuid', 'geteuid', 'getgid',
>> > 'getegid', 'gettid', and 'sysinfo' are now in 'kernel/sys.c'.
>>
>> Can we please remove these file references completely. They are going to be
>> stale sooner than later again and they really do not provide any value.
I actually refer to them a lot when locating syscall implementations,
which is how I found out that they were stale in the first place.
>
>+1
>
>Good idea!
>
>In the long run, I'd prefer to have a parsable format that can be used to
>generate both the header file and the stubs that we currently provide
>using SYSCALL_DEFINEx(), but before that I'd like the remaining two
>unistd.h files to be converted to syscall.tbl format (Nitesh is still working
>on that).
Sorry I didn't understand, is there anything I can do to follow up on this?
>
> Arnd
next prev parent reply other threads:[~2019-11-06 16:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 2:29 [PATCH 1/1] syscalls: Fix references to filenames containing syscall defs Mohammad Nasirifar
2019-11-05 9:34 ` Thomas Gleixner
2019-11-05 9:49 ` Arnd Bergmann
2019-11-06 16:47 ` Mohammad Nasirifar [this message]
2019-11-06 17:02 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106164756.GA558585@gmail.com \
--to=far.nasiri.m@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=farnasirim@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox