Re: [PATCH V9 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

Jason Wang
2019-11-07T14:31:19Z

On 2019/11/7 上午6:58, Alex Williamson wrote:
> On Wed, 6 Nov 2019 14:50:30 -0800
> Randy Dunlap <rdunlap@infradead.org> wrote:
>
>> On 11/5/19 11:05 PM, Jason Wang wrote:
>>> diff --git a/samples/Kconfig b/samples/Kconfig
>>> index c8dacb4dda80..13a2443e18e0 100644
>>> --- a/samples/Kconfig
>>> +++ b/samples/Kconfig
>>> @@ -131,6 +131,16 @@ config SAMPLE_VFIO_MDEV_MDPY
>>> mediated device. It is a simple framebuffer and supports
>>> the region display interface (VFIO_GFX_PLANE_TYPE_REGION).
>>>
>>> +config SAMPLE_VIRTIO_MDEV_NET
>>> + tristate "Build VIRTIO net example mediated device sample code -- loadable modules only"
>>> + depends on VIRTIO_MDEV && VHOST_RING && m
>>> + help
>>> + Build a networking sample device for use as a virtio
>>> + mediated device. The device coopreates with virtio-mdev bus
>> typo here:
>> cooperates
>>
> I can fix this on commit relative to V10 if there are no other issues
> raised:
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 13a2443e18e0..b7116d97cbbe 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -136,7 +136,7 @@ config SAMPLE_VIRTIO_MDEV_NET
> depends on VIRTIO_MDEV && VHOST_RING && m
> help
> Build a networking sample device for use as a virtio
> - mediated device. The device coopreates with virtio-mdev bus
> + mediated device. The device cooperates with virtio-mdev bus
> driver to present an virtio ethernet driver for
> kernel. It simply loopbacks all packets from its TX
> virtqueue to its RX virtqueue.
>
> Thanks,
> Alex

Thanks, per Michael request, I would rename mvnet and include this fix
in V11.

>