From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D32C5DF60 for ; Thu, 7 Nov 2019 07:19:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4ABC92187F for ; Thu, 7 Nov 2019 07:19:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Tp+LL/fB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727223AbfKGHTS (ORCPT ); Thu, 7 Nov 2019 02:19:18 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:43058 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726498AbfKGHTR (ORCPT ); Thu, 7 Nov 2019 02:19:17 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA77JDA7050480; Thu, 7 Nov 2019 07:19:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=GqFqeBt9Nv2tXaeUwh1OqUx18xyTylz1nlXDFPRLHzI=; b=Tp+LL/fBSbL7lpitzgt7noUZlojt53KQUBl44AeA1QvnqSE/9bHyXNE8875aGoUk+wds 2kgH9znUOZNv+VAPXzH4WBw8zc/hlCwqqtIQ3L4CGNnFBheiCobmc4cAUc41g7JY8/Bp s1FCGnoU6greVk/mgrwEf2LQ5Kt+aHr08fW1QfRVuGwe/mVDrEHejdRHXYu+HFWUfdQQ itwxFhLQEqLezoFY+Rs1Kc/fC93dkEo9wJxKoBZDmSI2xkH/chjaR3iThjs76yc8AVCv lEeE+i6vjp8ugAhkH3Av4MmO1MIuYB88nt2syxnrSvprAJ/GQU5egsB/VzAjNWO39YQv ig== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2w41w141fe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Nov 2019 07:19:12 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA77IutG131073; Thu, 7 Nov 2019 07:19:12 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2w41w92208-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Nov 2019 07:19:12 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xA77IohQ022769; Thu, 7 Nov 2019 07:18:51 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Nov 2019 23:18:50 -0800 Date: Thu, 7 Nov 2019 10:18:43 +0300 From: Dan Carpenter To: Amir Goldstein Cc: Colin King , Miklos Szeredi , overlayfs , kernel-janitors@vger.kernel.org, linux-kernel Subject: Re: [PATCH] ovl: create UUIDs for file systems that do not set the superblock UUID Message-ID: <20191107071843.GN10409@kadam> References: <20191106234301.283006-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9433 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911070074 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9433 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911070075 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 07, 2019 at 09:08:44AM +0200, Amir Goldstein wrote: > diff --git a/fs/overlayfs/ovl_entry.h b/fs/overlayfs/ovl_entry.h > index a8279280e88d..a0227c31fe17 100644 > --- a/fs/overlayfs/ovl_entry.h > +++ b/fs/overlayfs/ovl_entry.h > @@ -22,6 +22,8 @@ struct ovl_config { > struct ovl_sb { > struct super_block *sb; > dev_t pseudo_dev; > + /* Unusable (conflicting) uuid */ > + bool nouuid; Could we name this ignore_uuid, skip_uuid or bad_uuid or something? Otherwise we end up with double negatives. regards, dan carpenter