Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

Alexandre Belloni
2019-11-05T16:57:27Z

On 05/11/2019 17:53:18+0100, Alexandre Belloni wrote:
> On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > When RTC is used in 24H mode (and it is by this driver) the maximum
> > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> >
> > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > include/linux/mfd/rohm-bd70528.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Applied, thanks.
>

Actually, is there any point in doing that since "rtc: bd70528 add
BD71828 support" will conflict with it and correct the issue anyway?