Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

Vaittinen, Matti
2019-11-05T18:13:11Z

Hello Alexandre,

I'd expect the BD71828 support to still take a while. I don't expect it
to land in next kernel release. I'd prefer getting this fix in now (and
I hope it might also get merged to earlier releases by the 'fixes'
tag). So if it's not a problem for you then please apply this fix now -
I can rebase the BD71828 support when this fix is out :)

Br,
Matti Vaittinen

On Tue, 2019-11-05 at 17:57 +0100, Alexandre Belloni wrote:
> On 05/11/2019 17:53:18+0100, Alexandre Belloni wrote:
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the
> > > maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > >
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM
> > > bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > >
> > > ---
> > > include/linux/mfd/rohm-bd70528.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Applied, thanks.
> >
>
> Actually, is there any point in doing that since "rtc: bd70528 add
> BD71828 support" will conflict with it and correct the issue anyway?
>