From: Greg KH <gregkh@linuxfoundation.org>
To: Joel Stanley <joel@jms.id.au>
Cc: linux-fsi@lists.ozlabs.org, Jeremy Kerr <jk@ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [GIT PULL] fsi changes for 5.5
Date: Thu, 7 Nov 2019 15:17:36 +0100 [thread overview]
Message-ID: <20191107141736.GA109902@kroah.com> (raw)
In-Reply-To: <CACPK8XdtyQhK6OHJKbP=Fk50jRQQZeWzxqKDbX6kW0S5=eGuTg@mail.gmail.com>
On Thu, Nov 07, 2019 at 12:09:50PM +0000, Joel Stanley wrote:
> Hi Greg,
>
> Here's a set of changes I'd like merged for 5.5. They've been well
> tested in the openbmc tree over the past month or so as we've done
> hardware bring up using them. Aside from the three fixes I applied
> today they have seen time in linux-next too.
>
> This is the first time I've sent you a pull request, so please let me
> know if you'd prefer it done differently.
>
> The following changes since commit 755b0ef68f1802c786d0a53647145a5a7e46052a:
>
> fsi: aspeed: Clean up defines and documentation (2019-11-07 22:24:18 +1030)
The pull request looks good, but some of the individual patches, I have
questions on. Also, a diffstat would be good so that I know I got it
right for the next time you send this.
As they aren't here in the emails, let me try to figure out how to
respond:
- You have new dt bindings, yet no review from the DT
maintainers.
- you move things around in sysfs, yet no documentation updates
happen
- in 0005-fsi-Add-ast2600-master-driver.patch you have lots of
dev_dbg() lines left that shoudl be dropped as that's what
ftrace is for
- you don't have any reviewers for some of these patches, that's
not good to stick in a pull request.
- 0007-fsi-aspeed-Fix-OPB0-byte-order-register-values.patch does
not have a Fixes: tag, nor a stable@vger cc:, why not?
- 0010-fsi-fsi_master_class-can-be-static.patch has no changelog
text at all, which is not ok.
Can you fix all of this up, and send it as a set of normal patches so at
least I can review the things that do not have any other reviewers on
it?
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-07 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 12:09 [GIT PULL] fsi changes for 5.5 Joel Stanley
2019-11-07 14:17 ` Greg KH [this message]
2019-11-08 5:00 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107141736.GA109902@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@aj.id.au \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox