Re: [PATCH v2] selftests: add tests for clone3()

Christian Brauner
2019-11-06T16:00:41Z

On Wed, Nov 06, 2019 at 04:59:14PM +0100, Christian Brauner wrote:
> On Mon, Nov 04, 2019 at 02:18:46PM +0100, Adrian Reber wrote:
> > This adds tests for clone3() with different values and sizes
> > of struct clone_args.
> >
> > This selftest was initially part of of the clone3() with PID selftest.
> > After that patch was almost merged Eugene sent out a couple of patches
> > to fix problems with these test.
> >
> > This commit now only contains the clone3() selftest after the LPC
> > decision to rework clone3() with PID to allow setting the PID in
> > multiple PID namespaces including all of Eugene's patches.
> >
> > Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> > Signed-off-by: Adrian Reber <areber@redhat.com>
>
> Resending, since mutt messed-up the quoting due to a new configuration I
> was testing.
>
> A few more comments below.
>
> Also, would you be open to adding tests here for the newly added .stack
> and .stack_size API (cf. [1])?

Actually, forget that part for now. We can do this later in a separate
patchset.

Christian