From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBABFC6196 for ; Fri, 8 Nov 2019 11:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D0552084D for ; Fri, 8 Nov 2019 11:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573214274; bh=rEIAm3V1qILwCRot6idR0i5DGBcrYmtiS7UblRxpyFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=F4GVPwoy13IdCvhZn7/0z2Gzi0E+UHj+TePmScQHJdmEnY8sW14ClvjSlxcM8Ysni PQh6V4HncMrlMLB6rapkbZztmKG5AuZ2e0S0nN72xoJ+j5AjBPyUySALTR1ypGhGjF 6ww6/jC8HQaMJ5l7ha9dzrkKjzs8OVpBqBS9sb64= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390967AbfKHLo5 (ORCPT ); Fri, 8 Nov 2019 06:44:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:59832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390895AbfKHLos (ORCPT ); Fri, 8 Nov 2019 06:44:48 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB6FE2245C; Fri, 8 Nov 2019 11:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573213487; bh=rEIAm3V1qILwCRot6idR0i5DGBcrYmtiS7UblRxpyFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GNCc8AA+cQ4Qf8YzydxiYEkuLkTy0DrSTnQzl/YeYf4+S2rEcxxh6wRdyYSfhgyhQ xzuYoBUFSX4NuqFNckckTlDTFWOgAo251NIFSvwVJblTZ2TU0hpm3YdfQlL+fGZzHx XQ6I7l7AIVVztfOWXbF5Ro738JB9IAqbmdgLWRbs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chao Yu , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 4.14 067/103] f2fs: fix memory leak of percpu counter in fill_super() Date: Fri, 8 Nov 2019 06:42:32 -0500 Message-Id: <20191108114310.14363-67-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191108114310.14363-1-sashal@kernel.org> References: <20191108114310.14363-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu [ Upstream commit 4a70e255449c9a13eed7a6eeecc85a1ea63cef76 ] In fill_super -> init_percpu_info, we should destroy percpu counter in error path, otherwise memory allcoated for percpu counter will leak. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/super.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index e70975ca723b7..62a7821806593 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -2117,8 +2117,12 @@ static int init_percpu_info(struct f2fs_sb_info *sbi) if (err) return err; - return percpu_counter_init(&sbi->total_valid_inode_count, 0, + err = percpu_counter_init(&sbi->total_valid_inode_count, 0, GFP_KERNEL); + if (err) + percpu_counter_destroy(&sbi->alloc_valid_block_count); + + return err; } #ifdef CONFIG_BLK_DEV_ZONED -- 2.20.1