From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E15FA372C for ; Fri, 8 Nov 2019 11:46:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8691D222C2 for ; Fri, 8 Nov 2019 11:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573213593; bh=4HfRl1/n8kiP+P07FQPm8TIcE+1tLtK/NGNIKkyFGsg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=u4CiOdfaNB2LDph1Lx+PpRQPw8oNTp8vZEBysxZbTzCpF4z1Lyl3afy5PJbRAaC5J enPzNzSI/siEt8HuIb/6Ze6kzafLQyGg89FjXhrG3wkaeoCgO8lCfuRpfvuBaJedMv WTuksrjBvenkqmm2gFKR9DNuE5uhT6L5o4lbw5V0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390367AbfKHLqc (ORCPT ); Fri, 8 Nov 2019 06:46:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:33940 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391296AbfKHLqQ (ORCPT ); Fri, 8 Nov 2019 06:46:16 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E18E72084D; Fri, 8 Nov 2019 11:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573213576; bh=4HfRl1/n8kiP+P07FQPm8TIcE+1tLtK/NGNIKkyFGsg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eJhmZE2yzT5D4SsKzr9at8DOMam5+NGyX2yagKn0iTos0pZuaPUlCIorocdvTTpfE vBFNtIj8l4F5hS7fIs+miM/C8tJRqTTLU21305SkqzS8Ce7zJpL7wWIOdpAs1qvEBA X4m6HiNnzNXvokKqyXVixLW68rE0W54nsP8gn2QI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Colin Ian King , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 4.9 22/64] ASoC: sgtl5000: avoid division by zero if lo_vag is zero Date: Fri, 8 Nov 2019 06:45:03 -0500 Message-Id: <20191108114545.15351-22-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191108114545.15351-1-sashal@kernel.org> References: <20191108114545.15351-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit 9ab708aef61f5620113269a9d1bdb1543d1207d0 ] In the case where lo_vag <= SGTL5000_LINE_OUT_GND_BASE, lo_vag is set to zero and later vol_quot is computed by dividing by lo_vag causing a division by zero error. Fix this by avoiding a zero division and set vol_quot to zero in this specific case so that the lowest setting for i is correctly set. Signed-off-by: Colin Ian King Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/sgtl5000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 7406ea5c9a4f7..39810b713d5f2 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1217,7 +1217,7 @@ static int sgtl5000_set_power_regs(struct snd_soc_codec *codec) * Searching for a suitable index solving this formula: * idx = 40 * log10(vag_val / lo_cagcntrl) + 15 */ - vol_quot = (vag * 100) / lo_vag; + vol_quot = lo_vag ? (vag * 100) / lo_vag : 0; lo_vol = 0; for (i = 0; i < ARRAY_SIZE(vol_quot_table); i++) { if (vol_quot >= vol_quot_table[i]) -- 2.20.1