From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.4 27/44] signal: Properly deliver SIGSEGV from x86 uprobes
Date: Fri, 8 Nov 2019 06:47:03 -0500 [thread overview]
Message-ID: <20191108114721.15944-27-sashal@kernel.org> (raw)
In-Reply-To: <20191108114721.15944-1-sashal@kernel.org>
From: "Eric W. Biederman" <ebiederm@xmission.com>
[ Upstream commit 4a63c1ffd384ebdce40aac9c997dab68379137be ]
For userspace to tell the difference between an random signal
and an exception, the exception must include siginfo information.
Using SEND_SIG_FORCED for SIGSEGV is thus wrong, and it will result in
userspace seeing si_code == SI_USER (like a random signal) instead of
si_code == SI_KERNEL or a more specific si_code as all exceptions
deliver.
Therefore replace force_sig_info(SIGSEGV, SEND_SIG_FORCE, current)
with force_sig(SIG_SEGV, current) which gets this right and is shorter
and easier to type.
Fixes: 791eca10107f ("uretprobes/x86: Hijack return address")
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/x86/kernel/uprobes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/uprobes.c b/arch/x86/kernel/uprobes.c
index 178d63cac321b..60b12c14cf6fb 100644
--- a/arch/x86/kernel/uprobes.c
+++ b/arch/x86/kernel/uprobes.c
@@ -983,7 +983,7 @@ arch_uretprobe_hijack_return_addr(unsigned long trampoline_vaddr, struct pt_regs
pr_err("uprobe: return address clobbered: pid=%d, %%sp=%#lx, "
"%%ip=%#lx\n", current->pid, regs->sp, regs->ip);
- force_sig_info(SIGSEGV, SEND_SIG_FORCED, current);
+ force_sig(SIGSEGV, current);
}
return -1;
--
2.20.1
next prev parent reply other threads:[~2019-11-08 11:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 11:46 [PATCH AUTOSEL 4.4 01/44] iio: dac: mcp4922: fix error handling in mcp4922_write_raw Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 02/44] ALSA: pcm: signedness bug in snd_pcm_plug_alloc() Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 03/44] ARM: dts: at91/trivial: Fix USART1 definition for at91sam9g45 Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 04/44] ALSA: seq: Do error checks at creating system ports Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 05/44] gfs2: Don't set GFS2_RDF_UPTODATE when the lvb is updated Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 06/44] ASoC: dpcm: Properly initialise hw->rate_max Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 07/44] MIPS: BCM47XX: Enable USB power on Netgear WNDR3400v3 Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 08/44] ARM: dts: exynos: Fix sound in Snow-rev5 Chromebook Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 09/44] i40e: use correct length for strncpy Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 10/44] i40e: hold the rtnl lock on clearing interrupt scheme Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 11/44] i40e: Prevent deleting MAC address from VF when set by PF Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 12/44] ARM: dts: pxa: fix power i2c base address Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 13/44] rtl8187: Fix warning generated when strncpy() destination length matches the sixe argument Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 14/44] net: lan78xx: Bail out if lan78xx_get_endpoints fails Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 15/44] ASoC: sgtl5000: avoid division by zero if lo_vag is zero Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 16/44] ARM: dts: exynos: Disable pull control for S5M8767 PMIC Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 17/44] ath10k: wmi: disable softirq's while calling ieee80211_rx Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 18/44] mips: txx9: fix iounmap related issue Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 19/44] of: make PowerMac cache node search conditional on CONFIG_PPC_PMAC Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 20/44] ARM: dts: omap3-gta04: give spi_lcd node a label so that we can overwrite in other DTS files Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 21/44] ARM: dts: omap3-gta04: tvout: enable as display1 alias Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 22/44] ARM: dts: omap3-gta04: make NAND partitions compatible with recent U-Boot Sasha Levin
2019-11-08 11:46 ` [PATCH AUTOSEL 4.4 23/44] ARM: dts: omap3-gta04: keep vpll2 always on Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 24/44] dmaengine: dma-jz4780: Further residue status fix Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 25/44] signal: Always ignore SIGKILL and SIGSTOP sent to the global init Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 26/44] signal: Properly deliver SIGILL from uprobes Sasha Levin
2019-11-08 11:47 ` Sasha Levin [this message]
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 28/44] scsi: sym53c8xx: fix NULL pointer dereference panic in sym_int_sir() Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 29/44] ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 30/44] scsi: pm80xx: Corrected dma_unmap_sg() parameter Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 31/44] scsi: pm80xx: Fixed system hang issue during kexec boot Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 32/44] kprobes: Don't call BUG_ON() if there is a kprobe in use on free list Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 33/44] nvmem: core: return error code instead of NULL from nvmem_device_get Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 34/44] media: fix: media: pci: meye: validate offset to avoid arbitrary access Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 35/44] ALSA: intel8x0m: Register irq handler after register initializations Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 36/44] pinctrl: at91-pio4: fix has_config check in atmel_pctl_dt_subnode_to_map() Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 37/44] llc: avoid blocking in llc_sap_close() Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 38/44] powerpc/vdso: Correct call frame information Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 39/44] ARM: dts: socfpga: Fix I2C bus unit-address error Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 40/44] pinctrl: at91: don't use the same irqchip with multiple gpiochips Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 41/44] cxgb4: Fix endianness issue in t4_fwcache() Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 42/44] power: supply: ab8500_fg: silence uninitialized variable warnings Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 43/44] power: supply: max8998-charger: Fix platform data retrieval Sasha Levin
2019-11-08 11:47 ` [PATCH AUTOSEL 4.4 44/44] kernfs: Fix range checks in kernfs_get_target_path Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108114721.15944-27-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox