From: kbuild test robot <lkp@intel.com>
To: Dmitry Safonov <dima@arista.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Dmitry Safonov <0x7f454c46@gmail.com>,
Dmitry Safonov <dima@arista.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Slaby <jslaby@suse.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH 34/50] sparc: Add show_stack_loglvl()
Date: Fri, 8 Nov 2019 15:08:34 +0800 [thread overview]
Message-ID: <201911081505.R23PlN77%lkp@intel.com> (raw)
In-Reply-To: <20191106030542.868541-35-dima@arista.com>
[-- Attachment #1: Type: text/plain, Size: 5835 bytes --]
Hi Dmitry,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.4-rc6 next-20191107]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dmitry-Safonov/kallsyms-printk-Add-loglvl-to-print_ip_sym/20191108-124037
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 847120f859cc45e074204f4cf33c8df069306eb2
config: sparc-defconfig (attached as .config)
compiler: sparc-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/sparc/kernel/process_32.c: In function 'show_stack_loglvl':
>> arch/sparc/kernel/process_32.c:160:7: error: 'tsk' undeclared (first use in this function); did you mean 'task'?
if (!tsk)
^~~
task
arch/sparc/kernel/process_32.c:160:7: note: each undeclared identifier is reported only once for each function it appears in
>> arch/sparc/kernel/process_32.c:163:25: error: '_ksp' undeclared (first use in this function); did you mean 'sp'?
if (tsk == current && !_ksp)
^~~~
sp
vim +160 arch/sparc/kernel/process_32.c
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 146
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 147 /*
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 148 * The show_stack(), show_stack_loglvl() are external APIs which
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 149 * we do not use ourselves.
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 150 * The oops is printed in die_if_kernel.
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 151 */
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 152 void show_stack_loglvl(struct task_struct *task, unsigned long *sp,
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 153 const char *loglvl)
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 154 {
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 155 unsigned long pc, fp;
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 156 unsigned long task_base;
4d7b92ad572b4b arch/sparc/kernel/process_32.c Sam Ravnborg 2009-01-02 157 struct reg_window32 *rw;
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 158 int count = 0;
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 159
89e3f23da9c827 arch/sparc/kernel/process_32.c Tejun Heo 2013-04-30 @160 if (!tsk)
89e3f23da9c827 arch/sparc/kernel/process_32.c Tejun Heo 2013-04-30 161 tsk = current;
89e3f23da9c827 arch/sparc/kernel/process_32.c Tejun Heo 2013-04-30 162
89e3f23da9c827 arch/sparc/kernel/process_32.c Tejun Heo 2013-04-30 @163 if (tsk == current && !_ksp)
89e3f23da9c827 arch/sparc/kernel/process_32.c Tejun Heo 2013-04-30 164 __asm__ __volatile__("mov %%fp, %0" : "=r" (_ksp));
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 165
89e3f23da9c827 arch/sparc/kernel/process_32.c Tejun Heo 2013-04-30 166 task_base = (unsigned long) task_stack_page(tsk);
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 167 fp = (unsigned long) _ksp;
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 168 do {
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 169 /* Bogus frame pointer? */
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 170 if (fp < (task_base + sizeof(struct thread_info)) ||
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 171 fp >= (task_base + (PAGE_SIZE << 1)))
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 172 break;
4d7b92ad572b4b arch/sparc/kernel/process_32.c Sam Ravnborg 2009-01-02 173 rw = (struct reg_window32 *) fp;
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 174 pc = rw->ins[7];
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 175 printk("%s[%08lx : ", loglvl, pc);
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 176 printk("%s%pS ] ", loglvl, (void *) pc);
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 177 fp = rw->ins[6];
^1da177e4c3f41 arch/sparc/kernel/process.c Linus Torvalds 2005-04-16 178 } while (++count < 16);
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 179 printk("%s\n", loglvl);
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 180 }
17ea0216681912 arch/sparc/kernel/process_32.c Dmitry Safonov 2019-11-06 181
:::::: The code at line 160 was first introduced by commit
:::::: 89e3f23da9c827bfa9806c3d4da83a12c1c8543a sparc32: make show_stack() acquire %fp if @_ksp is not specified
:::::: TO: Tejun Heo <tj@kernel.org>
:::::: CC: Linus Torvalds <torvalds@linux-foundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 12823 bytes --]
next prev parent reply other threads:[~2019-11-08 7:08 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191106030542.868541-1-dima@arista.com>
2019-11-06 3:04 ` [PATCH 01/50] kallsyms/printk: Add loglvl to print_ip_sym() Dmitry Safonov
2019-11-06 4:38 ` Sergey Senozhatsky
2019-11-06 16:39 ` Dmitry Safonov
2019-11-13 15:49 ` Steven Rostedt
2019-11-06 3:04 ` [PATCH 02/50] alpha: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:04 ` [PATCH 03/50] arc: " Dmitry Safonov
2019-11-06 3:04 ` [PATCH 04/50] arm/asm: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06 3:04 ` [PATCH 05/50] arm: Add loglvl to unwind_backtrace() Dmitry Safonov
2019-11-06 9:12 ` Russell King - ARM Linux admin
2019-11-06 16:32 ` Dmitry Safonov
2019-11-06 3:04 ` [PATCH 06/50] arm: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06 3:04 ` [PATCH 07/50] arm: Wire up dump_backtrace_{entry,stm} Dmitry Safonov
2019-11-06 3:04 ` [PATCH 08/50] arm: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 09/50] arm64: Add loglvl to dump_backtrace() Dmitry Safonov
2019-11-06 13:25 ` Will Deacon
2019-11-06 16:00 ` Dmitry Safonov
2019-11-06 3:05 ` [PATCH 10/50] arm64: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 11/50] c6x: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 12/50] csky: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 13/50] h8300: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 14/50] hexagon: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 15/50] ia64: Pass log level as arg into ia64_do_show_stack() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 16/50] ia64: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 17/50] m68k: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 18/50] microblaze: Add loglvl to microblaze_unwind_inner() Dmitry Safonov
2019-11-07 8:59 ` Michal Simek
2019-11-08 7:52 ` kbuild test robot
2019-11-06 3:05 ` [PATCH 19/50] microblaze: Add loglvl to microblaze_unwind() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 20/50] microblaze: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 21/50] mips: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 22/50] nds32: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 23/50] nios2: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 24/50] openrisc: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 25/50] parisc: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 26/50] powerpc: " Dmitry Safonov
2019-11-06 9:52 ` Michael Ellerman
2019-11-06 16:01 ` Dmitry Safonov
2019-11-06 3:05 ` [PATCH 27/50] riscv: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 28/50] s390: " Dmitry Safonov
2019-11-06 3:05 ` [PATCH 29/50] sh: Add loglvl to dump_mem() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 30/50] sh: Remove needless printk() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 31/50] sh: Add loglvl to printk_address() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 32/50] sh: Add loglvl to show_trace() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 33/50] sh: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 34/50] sparc: " Dmitry Safonov
2019-11-06 3:33 ` David Miller
2019-11-06 16:02 ` Dmitry Safonov
2019-11-08 7:08 ` kbuild test robot [this message]
2019-11-06 3:05 ` [PATCH 35/50] um/sysrq: Remove needless variable sp Dmitry Safonov
2019-11-06 3:05 ` [PATCH 36/50] um: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 37/50] unicore32: Remove unused pmode argument in c_backtrace() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 38/50] unicore32: Add loglvl to c_backtrace() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 39/50] unicore32: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 40/50] x86: Add missing const qualifiers for log_lvl Dmitry Safonov
2019-11-06 3:05 ` [PATCH 41/50] x86: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 42/50] xtensa: Add loglvl to show_trace() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 43/50] xtensa: Add show_stack_loglvl() Dmitry Safonov
2019-11-06 4:13 ` Max Filippov
2019-11-06 8:15 ` Petr Mladek
2019-11-06 16:06 ` Dmitry Safonov
2019-11-06 16:44 ` Max Filippov
2019-11-06 3:05 ` [PATCH 44/50] sysrq: Use show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 45/50] x86/amd_gart: Print stacktrace for a leak with KERN_ERR Dmitry Safonov
2019-11-06 3:05 ` [PATCH 46/50] power: Use show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 47/50] kdb: Don't play with console_loglevel Dmitry Safonov
2019-11-06 3:05 ` [PATCH 48/50] sched: Print stack trace with KERN_INFO Dmitry Safonov
2019-11-06 3:05 ` [PATCH 49/50] kernel: Use show_stack_loglvl() Dmitry Safonov
2019-11-06 3:05 ` [PATCH 50/50] kernel: Rename show_stack_loglvl() => show_stack() Dmitry Safonov
2019-11-08 10:08 ` kbuild test robot
[not found] ` <20191106092039.GT4131@hirez.programming.kicks-ass.net>
[not found] ` <10db6fa1-5b17-ebe6-09e0-6335e09e4db8@arista.com>
[not found] ` <20191106203440.GH3079@worktop.programming.kicks-ass.net>
[not found] ` <20191106232512.GU25745@shell.armlinux.org.uk>
2019-11-07 7:27 ` [PATCH 00/50] Add log level to show_stack() Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911081505.R23PlN77%lkp@intel.com \
--to=lkp@intel.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox