Re: [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned long long

Sa, Nuno
2019-11-06T14:20:24Z

On Tue, 2019-11-05 at 20:28 +0000, Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the read of temp using of_property_read_u32_index is
> reading
> a u32 value into a unsigned long long. This relies on machine
> endianness
> to work correctly, so fix this by reading a u32 value and setting
> temp
> to this value.
>
> Addresses-Coverity: ("Reliance on integer endianness")
> Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/iio/temperature/ltc2983.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/temperature/ltc2983.c
> b/drivers/iio/temperature/ltc2983.c
> index ddf47023364b..d39c0d6b77f1 100644
> --- a/drivers/iio/temperature/ltc2983.c
> +++ b/drivers/iio/temperature/ltc2983.c
> @@ -444,8 +444,10 @@ static struct ltc2983_custom_sensor
> *__ltc2983_custom_sensor_new(
> else
> temp = __convert_to_raw(temp,
> resolution);
> } else {
> - of_property_read_u32_index(np, propname, index,
> - (u32 *)&temp);
> + u32 t32;
> +
> + of_property_read_u32_index(np, propname, index,
> &t32);
> + temp = t32;
> }
>
> for (j = 0; j < n_size; j++)

Acked-by: Nuno Sá <nuno.sa@analog.com>

Thanks,
Nuno Sá