Re: [PATCH v4 01/17] mfd: cros_ec: Add sensor_count and make check_features public

Jonathan Cameron
2019-11-16T11:49:31Z

On Mon, 11 Nov 2019 11:44:23 +0000
Lee Jones <lee.jones@linaro.org> wrote:

> On Fri, 08 Nov 2019, Enric Balletbo Serra wrote:
>
> > Missatge de Gwendal Grignou <gwendal@chromium.org> del dia dt., 5 de
> > nov. 2019 a les 23:28:
> > >
> > > Add a new function to return the number of MEMS sensors available in a
> > > ChromeOS Embedded Controller.
> > > It uses MOTIONSENSE_CMD_DUMP if available or a specific memory map ACPI
> > > registers to find out.
> > >
> > > Also, make check_features public as it can be useful for other drivers
> > > to know what the Embedded Controller supports.
> > >
> > > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> >
> > Version 3 was acked and I think we can maintain his ack, so:
> >
> > Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> >
> > Also,
> >
> > Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >
> > Lee, how you would like to handle this? I think will be safe for
> > patches 1/2/3 go through the platform-chrome tree without an immutable
> > branch. Patch 3 thought still needs and Ack from you if is fine.
>
> Please take the entire set, converting:
>
> s/Acked-for-MFD-by/Acked-by/
>
> ... and send me a pull-request to an immutable branch.
>

Agreed. Please do an immutable branch for the whole series v5 if everyone
else is happy with the changes in V5. (I think it was mostly my
comments on v4 so fingers crossed :)

I'll pull it if / when some follow up changes touch the resulting code
on the IIO side. Gwendall, if you can highlight if that occurs that
would be great as well!

Thanks,

Jonathan