Re: [PATCH v4 05/17] platform: chrome: cros_ec: Do not attempt to register a non-positive IRQ number

Gwendal Grignou
2019-11-14T00:58:36Z

On Mon, Nov 11, 2019 at 1:29 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
>
>
> On 10/11/19 13:17, Jonathan Cameron wrote:
> > On Tue, 5 Nov 2019 14:26:40 -0800
> > Gwendal Grignou <gwendal@chromium.org> wrote:
> >
> >> Add a layer of sanity checking to cros_ec_register against attempting to
> >> register IRQ values that are not strictly greater than 0.
> >>
> >> Signed-off-by: Enrico Granata <egranata@chromium.org>
> >> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> >
> > This strikes me as something that could be a potential fix to backport?
> > Any known cases of a negative irq getting to here or is this a by
> > inspection thing?
inspection only.

> >
> > Otherwise seems obviously correct.
> > Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
>
> Looks good to me:
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> Thanks,
> Enric
>
> > Jonathan
> >
> >> ---
> >> No changes in v4, v3.
> >> Changes in v2:
> >> Remove dual Enrico's signature.
> >>
> >> drivers/platform/chrome/cros_ec.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
> >> index 925f84dbf621..d3dfa27171e6 100644
> >> --- a/drivers/platform/chrome/cros_ec.c
> >> +++ b/drivers/platform/chrome/cros_ec.c
> >> @@ -149,7 +149,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
> >> return err;
> >> }
> >>
> >> - if (ec_dev->irq) {
> >> + if (ec_dev->irq > 0) {
> >> err = devm_request_threaded_irq(dev, ec_dev->irq,
> >> ec_irq_handler,
> >> ec_irq_thread,
> >