From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F736C43331 for ; Mon, 11 Nov 2019 17:02:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E09F720679 for ; Mon, 11 Nov 2019 17:02:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbfKKRCa (ORCPT ); Mon, 11 Nov 2019 12:02:30 -0500 Received: from mga05.intel.com ([192.55.52.43]:41408 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726857AbfKKRCa (ORCPT ); Mon, 11 Nov 2019 12:02:30 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 09:02:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,293,1569308400"; d="scan'208";a="249941137" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.21]) by FMSMGA003.fm.intel.com with ESMTP; 11 Nov 2019 09:02:25 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id 2670E301376; Mon, 11 Nov 2019 09:02:25 -0800 (PST) Date: Mon, 11 Nov 2019 09:02:25 -0800 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , jolsa@kernel.org, acme@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 10/13] perf stat: Use affinity for opening events Message-ID: <20191111170225.GF573472@tassilo.jf.intel.com> References: <20191107181646.506734-1-andi@firstfloor.org> <20191107181646.506734-11-andi@firstfloor.org> <20191111133107.GG12923@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111133107.GG12923@krava> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > #include > > @@ -440,6 +441,7 @@ static enum counter_recovery stat_handle_error(struct evsel *counter) > > ui__warning("%s event is not supported by the kernel.\n", > > perf_evsel__name(counter)); > > counter->supported = false; > > + counter->errored = true; > > how is errored different from supported? > why can't you use it? errored means that the event is still partially open, while supported means it is closed. While I guess it could be combined it seems cleaner to keep them separate. -Andi