Re: [PATCH v2 3/3] staging: wfx: replace u32 by __le32

Jerome Pouiller
2019-11-11T16:58:26Z

On Monday 11 November 2019 14:30:55 CET Jules Irenge wrote:
[...]
> - u32 count_rts_failures;
> - u32 count_ack_failures;
> - u32 count_rx_multicast_frames;
> - u32 count_rx_frames_success;
> - u32 count_rx_cmacicv_errors;
> - u32 count_rx_cmac_replays;
> - u32 count_rx_mgmt_ccmp_replays;
[...]
> + __le32 count_rts_failures;
> + __le32 count_rx_multicast_frames;
> + __le32 count_rx_cmacicv_errors;
> + __le32 count_rx_cmac_replays;
> + __le32 count_rx_mgmt_ccmp_replays;
> + __le32 count_rx_beacon;
> + __le32 count_miss_beacon;
> + __le32 count_ack_failures;
> + __le32 count_rx_frames_success;
> u32 count_rx_bipmic_errors;
> - u32 count_rx_beacon;
> - u32 count_miss_beacon;

Hello Jules,

Your patch reorders members of the structure. It will break API with the
chip.

--
Jérôme Pouiller