From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D15C17441 for ; Mon, 11 Nov 2019 18:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B877222C9 for ; Mon, 11 Nov 2019 18:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497741; bh=4nd80/nEjMUO2m1JwBIUNTi7+77i17sFMX/JwlOFRQw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rMGEFjzaEzSa/VeO2Z9XVBTs1F/EwqE/UXm0A3yjTu+mTLqTPJ8fpYuyarYdLatWT KsIIeBm0ZbhduX+wgsgQU3K3gCsIQeZWNq+Sr7PF15rcnyn2U9I+ZsAAVL0vrcLNd4 9EO0j8pGW3X++9Daszi11U5+K/3LSKFq0woaNBF8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728208AbfKKSmU (ORCPT ); Mon, 11 Nov 2019 13:42:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:33426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729493AbfKKSmP (ORCPT ); Mon, 11 Nov 2019 13:42:15 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48AAC20674; Mon, 11 Nov 2019 18:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497733; bh=4nd80/nEjMUO2m1JwBIUNTi7+77i17sFMX/JwlOFRQw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hbCfvEQu2x8wJkamvtpNaG0575/8mcdWuui6mwRZrs+HvzuW0rZUbvaVwP99VPpr4 4m0ISxLT+zq61gJ0AaKcA7qPwvQ4VUSlQ5PReEQ3LOxREGc77PEwQKfsBhlQcMxUFG Lj9yT5t0RcHR73NmXijCOFuMwreo0GOrjhwH7QZk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , Johan Hovold , "David S. Miller" Subject: [PATCH 4.19 009/125] nfc: netlink: fix double device reference drop Date: Mon, 11 Nov 2019 19:27:28 +0100 Message-Id: <20191111181440.716820399@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181438.945353076@linuxfoundation.org> References: <20191111181438.945353076@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian [ Upstream commit 025ec40b81d785a98f76b8bdb509ac10773b4f12 ] The function nfc_put_device(dev) is called twice to drop the reference to dev when there is no associated local llcp. Remove one of them to fix the bug. Fixes: 52feb444a903 ("NFC: Extend netlink interface for LTO, RW, and MIUX parameters support") Fixes: d9b8d8e19b07 ("NFC: llcp: Service Name Lookup netlink interface") Signed-off-by: Pan Bian Reviewed-by: Johan Hovold Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/nfc/netlink.c | 2 -- 1 file changed, 2 deletions(-) --- a/net/nfc/netlink.c +++ b/net/nfc/netlink.c @@ -1110,7 +1110,6 @@ static int nfc_genl_llc_set_params(struc local = nfc_llcp_find_local(dev); if (!local) { - nfc_put_device(dev); rc = -ENODEV; goto exit; } @@ -1170,7 +1169,6 @@ static int nfc_genl_llc_sdreq(struct sk_ local = nfc_llcp_find_local(dev); if (!local) { - nfc_put_device(dev); rc = -ENODEV; goto exit; }