From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1785AC43331 for ; Mon, 11 Nov 2019 18:44:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E25CF20674 for ; Mon, 11 Nov 2019 18:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497879; bh=ulVBYdmzhZH4kIJBSGLv7BaJr7sXNkk+SblnUPogkIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1/fXuNtN0yPAXZZ2+clpU61VgYCm8F1mAupPyT1VAEQpdf63d6IT/cLwCWcGSKttF EYR4AihUBYs03i9qHYST2NO3QoUJzeNXRr9ecxvC1c3lfWi6wwBHRNuPSVszXbSiPv TBGhbTQ/Gc8+0kvpbCFXHu2peiTM+wFBk5b7p4Dk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728565AbfKKSoh (ORCPT ); Mon, 11 Nov 2019 13:44:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:36294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728429AbfKKSog (ORCPT ); Mon, 11 Nov 2019 13:44:36 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B5A9420674; Mon, 11 Nov 2019 18:44:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497875; bh=ulVBYdmzhZH4kIJBSGLv7BaJr7sXNkk+SblnUPogkIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CFo5WPXtpiRUp7QpXDSJ8bf7pQZcX5zulg48fV6Twayv8G/cztuAjr2Pcu8cOgcuy UqVsV98E/EtIUWMeqg4HgqJChu3fofmAE4hCQJLo8+qa44CgDGG7C8WzcxnOcFdDYR DGcsw3W5jTNH6W6vBNx8w8nmz2S5Mvz18EHpzMBA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joakim Zhang , Marc Kleine-Budde Subject: [PATCH 4.19 044/125] can: flexcan: disable completely the ECC mechanism Date: Mon, 11 Nov 2019 19:28:03 +0100 Message-Id: <20191111181446.194944012@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181438.945353076@linuxfoundation.org> References: <20191111181438.945353076@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joakim Zhang commit 5e269324db5adb2f5f6ec9a93a9c7b0672932b47 upstream. The ECC (memory error detection and correction) mechanism can be activated or not, controlled by the ECCDIS bit in CAN_MECR. When disabled, updates on indications and reporting registers are stopped. So if want to disable ECC completely, had better assert ECCDIS bit, not just mask the related interrupts. Fixes: cdce844865be ("can: flexcan: add vf610 support for FlexCAN") Signed-off-by: Joakim Zhang Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/flexcan.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c @@ -1048,6 +1048,7 @@ static int flexcan_chip_start(struct net reg_mecr = priv->read(®s->mecr); reg_mecr &= ~FLEXCAN_MECR_ECRWRDIS; priv->write(reg_mecr, ®s->mecr); + reg_mecr |= FLEXCAN_MECR_ECCDIS; reg_mecr &= ~(FLEXCAN_MECR_NCEFAFRZ | FLEXCAN_MECR_HANCEI_MSK | FLEXCAN_MECR_FANCEI_MSK); priv->write(reg_mecr, ®s->mecr);