From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3057C43331 for ; Mon, 11 Nov 2019 18:42:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A2FC21783 for ; Mon, 11 Nov 2019 18:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497766; bh=qcPbvtM5qo4M4GqJ3W/AShFZvu0AH5WXdRDV5Xr6KZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iLDvytmWN7PnPpqcnr0fFAV2u9ag7nRwyBpsCQxXOc5ccUDUElV4yuX5ZRsJk8hsa LfcmRB3frdwyGS6wE0btMwneRXQgKxvsW4RY6RuxtnKgND6cULt09AkAXYKpCNj4Tb VpXC5kbMG8CMNvuRJC08bnb9Htb6HHHaTtSUPBcw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729554AbfKKSmp (ORCPT ); Mon, 11 Nov 2019 13:42:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:33870 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729541AbfKKSmk (ORCPT ); Mon, 11 Nov 2019 13:42:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3735220674; Mon, 11 Nov 2019 18:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497760; bh=qcPbvtM5qo4M4GqJ3W/AShFZvu0AH5WXdRDV5Xr6KZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T1cezZrPfeBJcWgvhdD5/oB/tAQRqSuuamLT7K6JP0ODDjuyFd33rFzljbfah0v6C aHjTktxFuhDnJsbQ3WP54J5cWuZEfTwMMflcoTCIGNMG9wNyjFDojtIVSP8NYh9Usg pOiODhqr7xy+wqDU6IbTwcLBNk1mZ+RlcWCDR1t0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Remigiusz=20Ko=C5=82=C5=82=C4=85taj?= , syzbot+e29b17e5042bbc56fae9@syzkaller.appspotmail.com, Johan Hovold , Marc Kleine-Budde Subject: [PATCH 4.19 050/125] can: mcba_usb: fix use-after-free on disconnect Date: Mon, 11 Nov 2019 19:28:09 +0100 Message-Id: <20191111181447.033273849@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181438.945353076@linuxfoundation.org> References: <20191111181438.945353076@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johan Hovold commit 4d6636498c41891d0482a914dd570343a838ad79 upstream. The driver was accessing its driver data after having freed it. Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer") Cc: stable # 4.12 Cc: Remigiusz Kołłątaj Reported-by: syzbot+e29b17e5042bbc56fae9@syzkaller.appspotmail.com Signed-off-by: Johan Hovold Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/usb/mcba_usb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/can/usb/mcba_usb.c +++ b/drivers/net/can/usb/mcba_usb.c @@ -887,9 +887,8 @@ static void mcba_usb_disconnect(struct u netdev_info(priv->netdev, "device disconnected\n"); unregister_candev(priv->netdev); - free_candev(priv->netdev); - mcba_urb_unlink(priv); + free_candev(priv->netdev); } static struct usb_driver mcba_usb_driver = {