From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86EFAC43331 for ; Mon, 11 Nov 2019 19:54:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 653732067B for ; Mon, 11 Nov 2019 19:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727222AbfKKTyj (ORCPT ); Mon, 11 Nov 2019 14:54:39 -0500 Received: from muru.com ([72.249.23.125]:41634 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbfKKTyj (ORCPT ); Mon, 11 Nov 2019 14:54:39 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D77878119; Mon, 11 Nov 2019 19:55:14 +0000 (UTC) Date: Mon, 11 Nov 2019 11:54:35 -0800 From: Tony Lindgren To: Mark Brown Cc: Luhua Xu , wsd_upstream@mediatek.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Subject: Re: Applied "spi: add power control when set_cs" to the spi tree Message-ID: <20191111195435.GW5610@atomide.com> References: <1572426234-30019-1-git-send-email-luhua.xu@mediatek.com> <20191031132342.100F1D020AA@fitzroy.sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031132342.100F1D020AA@fitzroy.sirena.org.uk> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Mark Brown [191031 13:24]: > The patch > > spi: add power control when set_cs > > has been applied to the spi tree at > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5 This patch causes a regression for many SPI devices as they assume spi_setup() return 0 on success and not a positive value. I've sent a fix for this as: spi: Fix regression to return zero on success instead of positive value Regards, Tony