From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F22C43331 for ; Mon, 11 Nov 2019 22:56:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE4B9214DB for ; Mon, 11 Nov 2019 22:56:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573512975; bh=Z3qpgytwGG/uM8u/1Veq7O94/qCL6tFO45pqS6ZAmOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rx++kURTI+alPBsYAQHOXQQnNNaejNmkXUaywWr0YlxoeUSSwB8bO2FFqeaew81rE 0jVU8hMBNnuBRQLpoHSFVpJZMRRSIwaJP8qHTIBhVQ81J3NgkCSoVmKn3lmrGJ1eCy 6CR99sqxDnGiPA8d5VzipaZFQc0I7VGgVASeRJu0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727101AbfKKW4O (ORCPT ); Mon, 11 Nov 2019 17:56:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:57678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbfKKW4O (ORCPT ); Mon, 11 Nov 2019 17:56:14 -0500 Received: from localhost (lfbn-ncy-1-150-155.w83-194.abo.wanadoo.fr [83.194.232.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57F4A20659; Mon, 11 Nov 2019 22:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573512973; bh=Z3qpgytwGG/uM8u/1Veq7O94/qCL6tFO45pqS6ZAmOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Rj/HCH/zb307UBe50EiURObwyYmarROa0C5OArwZ7/eka01/4riFU2QdBwpSCWDI0 AvpLAoOVBO6MoZ9KibjlFQaGVS4nOkJeZQAJhA+LaCN7wewZRLNykPgdrf50AcKziV M9zekoVIJznDJ4WdxgJm/7P+Sqa7CwyTjn3pU6uI= Date: Mon, 11 Nov 2019 23:56:11 +0100 From: Frederic Weisbecker To: Ingo Molnar Cc: Peter Zijlstra , LKML , "Paul E . McKenney" , Thomas Gleixner Subject: Re: [PATCH 1/4] irq_work: Convert flags to atomic_t Message-ID: <20191111225610.GB27917@lenoir> References: <20191108160858.31665-1-frederic@kernel.org> <20191108160858.31665-2-frederic@kernel.org> <20191111080058.GA72562@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191111080058.GA72562@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 09:00:58AM +0100, Ingo Molnar wrote: > > * Frederic Weisbecker wrote: > > > We need to convert flags to atomic_t in order to later fix an ordering > > issue on cmpxchg() failure. This will allow us to use atomic_fetch_or(). > > Also that clarify the nature of those flags. > > > > Signed-off-by: Frederic Weisbecker > > Cc: Paul E. McKenney > > Cc: Thomas Gleixner > > Cc: Peter Zijlstra > > Cc: Ingo Molnar > > --- > > include/linux/irq_work.h | 10 +++++++--- > > kernel/irq_work.c | 18 +++++++++--------- > > kernel/printk/printk.c | 2 +- > > 3 files changed, 17 insertions(+), 13 deletions(-) > > You missed the irq_work use in kernel/bpf/stackmap.c - see the fix below. > > Thanks, > > Ingo Oh thanks. Strange that I haven't seen a 0-day warning about those.