From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4318C43331 for ; Mon, 11 Nov 2019 23:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 932DF21655 for ; Mon, 11 Nov 2019 23:22:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DCmCfy7U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfKKXWz (ORCPT ); Mon, 11 Nov 2019 18:22:55 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:33556 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbfKKXWz (ORCPT ); Mon, 11 Nov 2019 18:22:55 -0500 Received: by mail-pg1-f193.google.com with SMTP id h27so10505367pgn.0 for ; Mon, 11 Nov 2019 15:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TcPWLJRMLACj8x101eDJpAx+ekq3xMep7NPhZ1ywhqI=; b=DCmCfy7URo+AnXHvcaYhhRJ2dmRBE5Amg98rGe9o59+0ANA+9wvO6c1u+JbIOxHHVH o4Sqbxr5cYzs4FwQGmhDuswTLueZnUSCBqlMMUpO4VKMR454FFNX5wCID47wzljdgH1E N4ulOsm1XDhgFn7T7QI963T+DG6WsG3ZXe27lcCSvs3/DNom1WAtuzUp1DE92zli31oG EYaWLFGWfgKOV9cS4hh9L/VjSGcLogQMJqGZOEqT+q/fbomNjTYD6VSZrYZvqWP6CnpS LGUByZ5o4bQ3kZCKWR3Hvx6vSM2jkU1Jl9CY/LVQ7AtwjSubC6w+6HfkJMDF7TFSPSf6 Wt5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TcPWLJRMLACj8x101eDJpAx+ekq3xMep7NPhZ1ywhqI=; b=s93KolQ8LdN/Tzu+ykbEzv3Ibq7oaUHkynfIFs9nz5BKcR/K1ltlymmrSCrm+RXwwa gis2Y9tiSKpqWT7lDdnB6bkvVGBLkxCZpirYxyIaqOeHwCaxP3tH+vY1Xgsj9mixuw7J NzJh0YSGvDhHoXb86jzauV6Oxremo8zrmRL8rr36aLOwAeviGNKFfg5PURVP4Jq6BdR9 ZTmrlCVr7uuLHQIlaEmJnV7YgmdjNPALBNrreryic1zxm65jmGX60vjfXX6P10ZuYy/M usXdl0DKKG/zLfgymRc1XdpODmKEK7s5+xI706IcJABZNag+w8s9qTE0vJYxeQRkJirX 5Ciw== X-Gm-Message-State: APjAAAVN4lqa4LRHFW4OrKQvG5aCwoqgDZ9E+Fw3XkDyw3kJOO4vI3gb 1M/ZCOAslrPnQbwXSo9PWYdHhQ== X-Google-Smtp-Source: APXvYqzcPTauYRY2lULj0daCQNC8c+T2DIe/TTKA7uwYAWW/MbUINxhbzx9h7gdFzgUOMNNH/at/Mg== X-Received: by 2002:a63:b44e:: with SMTP id n14mr6970009pgu.154.1573514574223; Mon, 11 Nov 2019 15:22:54 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id h195sm115737pfe.88.2019.11.11.15.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 15:22:53 -0800 (PST) Date: Mon, 11 Nov 2019 15:22:51 -0800 From: Bjorn Andersson To: Tero Kristo Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, s-anna@ti.com Subject: Re: [PATCH 06/17] remoteproc/omap: Add the rproc ops .da_to_va() implementation Message-ID: <20191111232251.GH3108315@builder> References: <20191028124238.19224-1-t-kristo@ti.com> <20191028124238.19224-7-t-kristo@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028124238.19224-7-t-kristo@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 28 Oct 05:42 PDT 2019, Tero Kristo wrote: > From: Suman Anna > > An implementation for the rproc ops .da_to_va() has been added > that provides the address translation between device addresses > to kernel virtual addresses for internal RAMs present on that > particular remote processor device. The implementation provides > the translations based on the addresses parsed and stored during > the probe. > > This ops gets invoked by the exported rproc_da_to_va() function > and allows the remoteproc core's ELF loader to be able to load > program data directly into the internal memories. > > Signed-off-by: Suman Anna > Signed-off-by: Tero Kristo > --- > drivers/remoteproc/omap_remoteproc.c | 35 ++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c > index bbd6ff360e10..0524f7e0ffa4 100644 > --- a/drivers/remoteproc/omap_remoteproc.c > +++ b/drivers/remoteproc/omap_remoteproc.c > @@ -230,10 +230,45 @@ static int omap_rproc_stop(struct rproc *rproc) > return 0; > } > > +/* > + * Internal Memory translation helper Please format this as kerneldoc. > + * > + * Custom function implementing the rproc .da_to_va ops to provide address > + * translation (device address to kernel virtual address) for internal RAMs > + * present in a DSP or IPU device). The translated addresses can be used > + * either by the remoteproc core for loading, or by any rpmsg bus drivers. > + */ > +static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, int len) > +{ > + struct omap_rproc *oproc = rproc->priv; > + void *va = NULL; > + int i; > + u32 offset; > + > + if (len <= 0) > + return NULL; > + > + if (!oproc->num_mems) > + return NULL; > + > + for (i = 0; i < oproc->num_mems; i++) { > + if (da >= oproc->mem[i].dev_addr && da + len <= > + oproc->mem[i].dev_addr + oproc->mem[i].size) { > + offset = da - oproc->mem[i].dev_addr; > + /* __force to make sparse happy with type conversion */ > + va = (__force void *)(oproc->mem[i].cpu_addr + offset); Replace va = and break; with just a return here. > + break; > + } > + } > + > + return va; return NULL here. Regards, Bjorn