From: Jonathan Corbet <corbet@lwn.net>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [RFC PATCH] Documentation: filesystems: convert fuse to RST
Date: Tue, 12 Nov 2019 08:55:16 -0700 [thread overview]
Message-ID: <20191112085516.15ed4b1a@lwn.net> (raw)
In-Reply-To: <20191108164619.30401-1-dwlsalmeida@gmail.com>
On Fri, 8 Nov 2019 13:46:19 -0300
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com> wrote:
> Converts fuse.txt to reStructuredText format, improving the presentation
> without changing much of the underlying content.
>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
This generally looks like a good conversion, thanks! That said, I have a
few small comments...
- You should copy the FUSE maintainer on this change. You can find the
relevant information in the MAINTAINERS file or with
get_maintainer.pl.
- Speaking of MAINTAINERS, you also need to fix the reference to
fuse.txt there when you rename the file.
- You are reasonably well restrained in your use of markup, but it would
be good to pull back just a bit more. Just FUSE everywhere rather than
``FUSE`` in some places. Less **emphasis**. Remember that the
readability of the plain-text file is important.
- This file contains information that is useful to system
administrators, so I think that a move to admin-guide would be
warranted.
Thanks,
jon
prev parent reply other threads:[~2019-11-12 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 16:46 [RFC PATCH] Documentation: filesystems: convert fuse to RST Daniel W. S. Almeida
2019-11-12 15:55 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112085516.15ed4b1a@lwn.net \
--to=corbet@lwn.net \
--cc=dwlsalmeida@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox