From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B45C43331 for ; Tue, 12 Nov 2019 10:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60E5A206BA for ; Tue, 12 Nov 2019 10:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727132AbfKLKmT (ORCPT ); Tue, 12 Nov 2019 05:42:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:47140 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725874AbfKLKmT (ORCPT ); Tue, 12 Nov 2019 05:42:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2A272AD22; Tue, 12 Nov 2019 10:42:17 +0000 (UTC) Date: Tue, 12 Nov 2019 10:42:16 +0000 From: Luis Henriques To: Ilya Dryomov Cc: Sage Weil , Jeff Layton , "Yan, Zheng" , Ceph Development , LKML Subject: Re: [RFC PATCH 0/2] ceph: safely use 'copy-from' Op on Octopus OSDs Message-ID: <20191112104216.GA2028@hermes.olymp> References: <20191108141555.31176-1-lhenriques@suse.com> <20191108164758.GA1760@hermes.olymp> <20191108171616.GA2569@hermes.olymp> <20191108173101.GA3300@hermes.olymp> <20191111163036.GA20513@hermes.olymp> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 11, 2019 at 09:51:47PM +0100, Ilya Dryomov wrote: > On Mon, Nov 11, 2019 at 5:30 PM Luis Henriques wrote: > > > > On Fri, Nov 08, 2019 at 05:31:01PM +0000, Luis Henriques wrote: > > > > > > - You'll need to add it for both OSDMap::Incremental and OSDMap > > > > - You'll need to make the encoding condition by updating the block like > > > > the one below from OSDMap::encode() > > > > > > > > uint8_t v = 9; > > > > if (!HAVE_FEATURE(features, SERVER_LUMINOUS)) { > > > > v = 3; > > > > } else if (!HAVE_FEATURE(features, SERVER_MIMIC)) { > > > > v = 6; > > > > } else if (!HAVE_FEATURE(features, SERVER_NAUTILUS)) { > > > > v = 7; > > > > } > > > > > > > > to include a SERVER_OCTOPUS case too. Same goes for Incremental::encode() > > > > > > Awesome, thanks! I'll give it a try, and test it with the appropriate > > > kernel client side changes to use this. > > > > Ok, I've got the patch bellow for the OSD code, which IIRC should do > > exactly what we want: duplicate the require_osd_release in the client > > side. > > > > Now, in order to quickly test this I've started adding flags to the > > CEPH_FEATURES_SUPPORTED_DEFAULT definition. SERVER_MIMIC *seemed* to be > > Ok, but once I've added SERVER_NAUTILUS I've realized that we'll need to > > handle TYPE_MSGR2 address. Which is a _big_ thing. Is anyone already > > looking into adding support for msgr v2 to the kernel client? > > It should be easy enough to hack around it for testing purposes. > > I made some initial steps and hope to be able to dedicate the 5.6 cycle > to it. Yeah, I'll give that a try; adding support for that new address type shouldn't be a big deal. I was just wondering if that wasn't already being handling by any new msgrv2 code under development. Thanks, Ilya. Cheers, -- Luís