Re: [RFC 01/11] dt-bindings: soc: Add Realtek RTD1195 chip info binding

Rob Herring
2019-11-06T04:41:55Z

On Sun, Nov 03, 2019 at 02:36:35AM +0100, Andreas Färber wrote:
> Define a binding for RTD1195 and later SoCs' chip info registers.
> Add the new directory to MAINTAINERS.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> Note: The binding gets extended compatibly later for up to three reg entries.
>
> .../bindings/soc/realtek/realtek,rtd1195-chip.yaml | 32 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
> new file mode 100644
> index 000000000000..565ad2419553
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/realtek/realtek,rtd1195-chip.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/realtek/realtek,rtd1195-chip.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Realtek RTD1195 chip identification
> +
> +maintainers:
> + - Andreas Färber <afaerber@suse.de>
> +
> +description: |
> + The Realtek SoCs have some registers to identify the chip and revision.
> +
> +properties:
> + compatible:
> + const: "realtek,rtd1195-chip"

Don't need quotes.

> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg

Add here:

additionalProperties: false

> +
> +examples:
> + - |
> + chip-info@1801a200 {
> + compatible = "realtek,rtd1195-chip";
> + reg = <0x1801a200 0x8>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f33adc430230..5c61cf5a44cb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2188,6 +2188,7 @@ L: linux-realtek-soc@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> F: arch/arm64/boot/dts/realtek/
> F: Documentation/devicetree/bindings/arm/realtek.yaml
> +F: Documentation/devicetree/bindings/soc/realtek/
>
> ARM/RENESAS ARM64 ARCHITECTURE
> M: Geert Uytterhoeven <geert+renesas@glider.be>
> --
> 2.16.4
>