From: Vincent Cheng <vincent.cheng.xh@renesas.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: "richardcochran@gmail.com" <richardcochran@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] ptp: ptp_clockmatrix: Fix build error
Date: Tue, 12 Nov 2019 14:47:58 +0000 [thread overview]
Message-ID: <20191112144724.GA15686@renesas.com> (raw)
In-Reply-To: <20191112143514.10784-1-yuehaibing@huawei.com>
On Tue, Nov 12, 2019 at 09:35:14AM EST, YueHaibing wrote:
>When do randbuilding, we got this warning:
>
>WARNING: unmet direct dependencies detected for PTP_1588_CLOCK
> Depends on [n]: NET [=y] && POSIX_TIMERS [=n]
> Selected by [y]:
> - PTP_1588_CLOCK_IDTCM [=y]
>
>Make PTP_1588_CLOCK_IDTCM depends on PTP_1588_CLOCK to fix this.
>
>Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>---
> drivers/ptp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
>index c48ad23..b45d2b8 100644
>--- a/drivers/ptp/Kconfig
>+++ b/drivers/ptp/Kconfig
>@@ -121,7 +121,7 @@ config PTP_1588_CLOCK_KVM
>
> config PTP_1588_CLOCK_IDTCM
> tristate "IDT CLOCKMATRIX as PTP clock"
>- select PTP_1588_CLOCK
>+ depends on PTP_1588_CLOCK
> default n
> help
> This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
>--
Oops. Thank-you for the fix.
Reviewed-by: Vincent Cheng <vincent.cheng.xh@renesas.com>
next prev parent reply other threads:[~2019-11-12 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:35 [PATCH net-next] ptp: ptp_clockmatrix: Fix build error YueHaibing
2019-11-12 14:47 ` Vincent Cheng [this message]
2019-11-12 20:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112144724.GA15686@renesas.com \
--to=vincent.cheng.xh@renesas.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox