Re: [PATCH -next] thermal: power_allocator: Fix Kconfig warning

Quentin Perret
2019-11-12T15:13:27Z

On Tuesday 12 Nov 2019 at 22:51:14 (+0800), YueHaibing wrote:
> When do randbuiding, we got this:
>
> WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
> Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
> Selected by [y]:
> - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>

This will not cause run-time problems, but I guess the warning is
annoying so ...

> Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR also depends on ENERGY_MODEL.
>
> Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")

Daniel: can we rely on this sha1 ? Or is this branch force-pushed ?

> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 59b79fc..5e9e038 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -108,6 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
>
> config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> bool "power_allocator"
> + depends on ENERGY_MODEL
> select THERMAL_GOV_POWER_ALLOCATOR
> help
> Select this if you want to control temperature based on
> --
> 2.7.4

Thanks,
Quentin