From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD522C43331 for ; Wed, 13 Nov 2019 02:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 894A821D7F for ; Wed, 13 Nov 2019 02:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573611464; bh=mHyJix8TS0iTdx7zM4Zt5aMG7j8CE7oo13sYuj57jpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vuFit0t+uKcmqnzKMUT31X3+oPnHal2LyJtunR9uFABjdmBnaksBdc9hh8dwNFGvI Z2B1yZ5CVIK38vgvRCHf4qhQfatlmDAwSS2BPfj7j1q6nlrrK2pSs/T+DuIA2JBF9O lpP3BUBojkj5s/kMnmKfX9m6xbsEA1HspDg8w+64= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730442AbfKMCRn (ORCPT ); Tue, 12 Nov 2019 21:17:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:47886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729333AbfKMBz5 (ORCPT ); Tue, 12 Nov 2019 20:55:57 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBAA42245C; Wed, 13 Nov 2019 01:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573610156; bh=mHyJix8TS0iTdx7zM4Zt5aMG7j8CE7oo13sYuj57jpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ASq15h5C9yqibQAZJESHfTAB0QobE6gLs8mQ/T05ej29GSqvz5Xo1XLgtUqdYCumf Wscp6FPQycp8EkiZ7m1xMlAZ6gT0b+2Z6FfqizWi50OFzmTFcriE/XCJfBDQqKrWmK bB0Uu2S6siVGBTlmllRjmx5gjtcoU9TA0n5JEY20= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Huibin Hong , Emil Renner Berthing , Mark Brown , Sasha Levin , linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 200/209] spi: rockchip: initialize dma_slave_config properly Date: Tue, 12 Nov 2019 20:50:16 -0500 Message-Id: <20191113015025.9685-200-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113015025.9685-1-sashal@kernel.org> References: <20191113015025.9685-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huibin Hong [ Upstream commit dd8fd2cbc73f8650f651da71fc61a6e4f30c1566 ] The rxconf and txconf structs are allocated on the stack, so make sure we zero them before filling out the relevant fields. Signed-off-by: Huibin Hong Signed-off-by: Emil Renner Berthing Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-rockchip.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index fdcf3076681b5..185bbdce62b14 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c @@ -445,6 +445,9 @@ static int rockchip_spi_prepare_dma(struct rockchip_spi *rs) struct dma_slave_config rxconf, txconf; struct dma_async_tx_descriptor *rxdesc, *txdesc; + memset(&rxconf, 0, sizeof(rxconf)); + memset(&txconf, 0, sizeof(txconf)); + spin_lock_irqsave(&rs->lock, flags); rs->state &= ~RXBUSY; rs->state &= ~TXBUSY; -- 2.20.1