From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A3FEC17441 for ; Wed, 13 Nov 2019 02:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2879D206B6 for ; Wed, 13 Nov 2019 02:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573611039; bh=km4X5vKqo7Inc5aIAMHNteD9crBieiW9GgVbiAH/MyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=A01IJZRDB1HGJi2wvFxlWuRX5o1qCuwsmeLFSvpx8KJg2kjXKKWAXSap3ROwcFx1O yFX09KIRdMToUZgwvS5uEXVzHl+sjswV2eKTBFhV2ODX0DD/F0N8yI9AMfYUfqZdX9 XGBaTOG4PKZKFTarlsHXj2tFMp3v6iKoINti/RX4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730676AbfKMCKi (ORCPT ); Tue, 12 Nov 2019 21:10:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:53584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730178AbfKMB7N (ORCPT ); Tue, 12 Nov 2019 20:59:13 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BF4C22474; Wed, 13 Nov 2019 01:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573610353; bh=km4X5vKqo7Inc5aIAMHNteD9crBieiW9GgVbiAH/MyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UqOA7cT77gwFvbgtLVlipbbM5hCaRHHtUKh1bGP4YVg9x+F0PclPyiezcWZZ/ok/H IWJUYhzStcLl5aHdG215YgSftRG4uIVDI2aDr7LBoj3rpbSrxC8vHVgCNvIG2R/Djn 0gaYLjsfcnhF/fRE0+CEgFYRzmZHmfJf24f4gRvw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nicolin Chen , Guenter Roeck , Sasha Levin , linux-hwmon@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 104/115] hwmon: (ina3221) Fix INA3221_CONFIG_MODE macros Date: Tue, 12 Nov 2019 20:56:11 -0500 Message-Id: <20191113015622.11592-104-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191113015622.11592-1-sashal@kernel.org> References: <20191113015622.11592-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolin Chen [ Upstream commit 791ebc9d34e9d212fc03742c31654b017d385926 ] The three INA3221_CONFIG_MODE macros are not correctly defined here. The MODE3-1 bits are located at BIT 2-0 according to the datasheet. So this patch just fixes them by shifting all of them with a correct offset. However, this isn't a crital bug fix as the driver does not use any of them at this point. Signed-off-by: Nicolin Chen Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/ina3221.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c index e6b49500c52ae..8c9555313fc3d 100644 --- a/drivers/hwmon/ina3221.c +++ b/drivers/hwmon/ina3221.c @@ -38,9 +38,9 @@ #define INA3221_WARN3 0x0c #define INA3221_MASK_ENABLE 0x0f -#define INA3221_CONFIG_MODE_SHUNT BIT(1) -#define INA3221_CONFIG_MODE_BUS BIT(2) -#define INA3221_CONFIG_MODE_CONTINUOUS BIT(3) +#define INA3221_CONFIG_MODE_SHUNT BIT(0) +#define INA3221_CONFIG_MODE_BUS BIT(1) +#define INA3221_CONFIG_MODE_CONTINUOUS BIT(2) #define INA3221_RSHUNT_DEFAULT 10000 -- 2.20.1