From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E21C43331 for ; Wed, 13 Nov 2019 02:36:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E319206BA for ; Wed, 13 Nov 2019 02:36:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XgT9OOUk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727481AbfKMCgM (ORCPT ); Tue, 12 Nov 2019 21:36:12 -0500 Received: from mail-pg1-f201.google.com ([209.85.215.201]:41460 "EHLO mail-pg1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbfKMCgJ (ORCPT ); Tue, 12 Nov 2019 21:36:09 -0500 Received: by mail-pg1-f201.google.com with SMTP id e6so742951pgc.8 for ; Tue, 12 Nov 2019 18:36:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=j/m5gKoO0jXE5BYiRELmqLQO+KOEzq6qVcGYQdzOaSA=; b=XgT9OOUk3Yzbi5DcZ2hay2pQFUGc1C8JY/5SA0LlfseAK+RhPY+71H6xpSldWlhSUe R9GgGqV4at+vdSBUE8daDaNeFdK+nLrVVaDX/LAkaLhuF3uf6imXA+7dLiENKvXLfaWp iLdt55FdJCRJZ1R1A5pWhqZj+jjlwzp4usrjP2FUtoZyo114DxMiDZ5jfZHluHJgnbBA 8QRRFNIdOTHX9gS5bdLMBT6zr1BxIyqjIk4upS3q+n7pWPeFmF5OfwpZbWYU8drHzMhO jjpTtkobVVPWzyCvqti8iv4ADbXMyvD0D0UsAez45khHi5TiY/0D42l5dprS4XOUaWpD vb6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=j/m5gKoO0jXE5BYiRELmqLQO+KOEzq6qVcGYQdzOaSA=; b=CkQqZhZwj/4aQIgyEUeaotJRaohppxxtj5/RDIVcQ+TeoERdA0YFw6/cRiEHjoPB9n 5y9D4mXJ3n1d9npIOUbJAOfJY6gnnwLaWpGjwn4H0H8U0EGtEQO7Q+7Jh+IdhCqltPAN 7jeP13MRffNozTSmcgX1Gs7EvItNtRosnToz1ootWXoy2lNsLteDJcsorUCFKqgtMFt6 B9wuo0ryrnW3hES1spx5wrD5dWZfb708r7DSNnip9W+0sfN5Waf/GAgTMnZZRoWiITYJ H0q40eQeexm9DqlGFmG7ZjGZOXmWBx33TXzIPYPSS+V7PiO/XHF9W0ikybrUxSzEM+M8 kkEw== X-Gm-Message-State: APjAAAUhtjED05kbzLyF7Yd/g32VAAJNkppgo46b5o1ZLLxoANXSbzL2 nO+c6ZEK/WMqqF3lsP/80ptePH5APq1eqdo= X-Google-Smtp-Source: APXvYqy/iTcBCYhhvymxkn9JScQwGqIbVYAjgoqO+QvFZA1fjoiQ8ng2UZoFhvy3CTVKg4ofr5GXs6lQhmmutcw= X-Received: by 2002:a63:8f5e:: with SMTP id r30mr933408pgn.146.1573612568112; Tue, 12 Nov 2019 18:36:08 -0800 (PST) Date: Tue, 12 Nov 2019 18:35:59 -0800 In-Reply-To: <20191113023559.62295-1-saravanak@google.com> Message-Id: <20191113023559.62295-2-saravanak@google.com> Mime-Version: 1.0 References: <20191113023559.62295-1-saravanak@google.com> X-Mailer: git-send-email 2.24.0.rc1.363.gb1bccd3e3d-goog Subject: [PATCH v1] driver core: Clarify documentation for fwnode_operations.add_links() From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , "Rafael J. Wysocki" , Len Brown Cc: Saravana Kannan , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The wording was a bit ambiguous. So update it to make it clear. Signed-off-by: Saravana Kannan --- include/linux/fwnode.h | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h index 766ff9bb5876..23df37f85398 100644 --- a/include/linux/fwnode.h +++ b/include/linux/fwnode.h @@ -94,15 +94,16 @@ struct fwnode_reference_args { * available suppliers. * * Return 0 if device links have been successfully created to all - * the suppliers this device needs to create device links to or if - * the supplier information is not known. + * the known suppliers of this device or if the supplier + * information is not known. * - * Return -ENODEV if and only if the suppliers needed for probing - * the device are not yet available to create device links to. + * Return -ENODEV if the suppliers needed for probing this device + * have not been registered yet (because device links can only be + * created to devices registered with the driver core). * - * Return -EAGAIN if there are suppliers that need to be linked to - * that are not yet available but none of those suppliers are - * necessary for probing this device. + * Return -EAGAIN if some of the suppliers of this device have not + * been registered yet, but none of those suppliers are necessary + * for probing the device. */ struct fwnode_operations { struct fwnode_handle *(*get)(struct fwnode_handle *fwnode); -- 2.24.0.rc1.363.gb1bccd3e3d-goog