Re: [PATCH v8 1/6] software node: rename is_array to is_inline

Dmitry Torokhov
2019-11-13T08:08:19Z

On Wed, Nov 13, 2019 at 07:52:43AM +0100, Bjørn Mork wrote:
> Dmitry Torokhov <dmitry.torokhov@gmail.com> writes:
>
> > We do not need a special flag to know if we are dealing with an array,
> > as we can get that data from ratio between element length and the data
> > size, however we do need a flag to know whether the data is stored
> > directly inside property_entry or separately.
>
> Doesn't a non-null prop->pointer tell you this?

No it does not because pointer is a part of a union.

>
> And inverting the flag is unnecessarily risky IMHO. An all-zero prop
> might now result in dereferencing a NULL prop->pointer instead of using
> the empty prop->value. Now I haven't looked at the code to see if this
> is a real problem. But I believe it's better not having to do that
> anyway...

All-zero property is a terminator and thus we will not dereference
anything.

Thanks.

--
Dmitry