From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F44EC43331 for ; Wed, 13 Nov 2019 10:34:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F123222CD for ; Wed, 13 Nov 2019 10:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727427AbfKMKeL (ORCPT ); Wed, 13 Nov 2019 05:34:11 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54444 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbfKMKeL (ORCPT ); Wed, 13 Nov 2019 05:34:11 -0500 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xADAV5tI192257 for ; Wed, 13 Nov 2019 05:34:10 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w7qdb9ef5-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 13 Nov 2019 05:34:09 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 13 Nov 2019 10:33:46 -0000 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 13 Nov 2019 10:33:42 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xADAXfNR22479104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Nov 2019 10:33:42 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D53AEAE045; Wed, 13 Nov 2019 10:33:41 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6DE7EAE051; Wed, 13 Nov 2019 10:33:40 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.206.160]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 13 Nov 2019 10:33:40 +0000 (GMT) Date: Wed, 13 Nov 2019 11:33:37 +0100 From: Mike Rapoport To: Shiyang Ruan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Cao jin Subject: Re: [PATCH] mm/memblock: Correct doc for function References: <20191113051822.3296-1-ruansy.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113051822.3296-1-ruansy.fnst@cn.fujitsu.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19111310-4275-0000-0000-0000037D58C6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19111310-4276-0000-0000-00003890B9AF Message-Id: <20191113103336.GB28740@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-13_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911130099 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 13, 2019 at 01:18:22PM +0800, Shiyang Ruan wrote: > From: Cao jin > > Change "max_addr" to "end" for less confusion > in memblock_alloc_range_nid comments. > > Signed-off-by: Cao jin Reviewed-by: Mike Rapoport > --- > mm/memblock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Suppose this still goes to Andrew's -mm. > > diff --git a/mm/memblock.c b/mm/memblock.c > index ceb6761f526d..203ed317551b 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -1321,7 +1321,7 @@ __next_mem_pfn_range_in_zone(u64 *idx, struct zone *zone, > * @nid: nid of the free area to find, %NUMA_NO_NODE for any node > * > * The allocation is performed from memory region limited by > - * memblock.current_limit if @max_addr == %MEMBLOCK_ALLOC_ACCESSIBLE. > + * memblock.current_limit if @end == %MEMBLOCK_ALLOC_ACCESSIBLE. > * > * If the specified node can not hold the requested memory the > * allocation falls back to any node in the system > -- > 2.21.0 > > > -- Sincerely yours, Mike.