Re: [PATCH v6 2/3] dwc: PCI: intel: PCIe RC controller driver

Andy Shevchenko
2019-11-13T11:00:16Z

On Wed, Nov 13, 2019 at 03:21:21PM +0800, Dilip Kota wrote:
> Add support to PCIe RC controller on Intel Gateway SoCs.
> PCIe controller is based of Synopsys DesignWare PCIe core.
>
> Intel PCIe driver requires Upconfigure support, Fast Training
> Sequence and link speed configurations. So adding the respective
> helper functions in the PCIe DesignWare framework.
> It also programs hardware autonomous speed during speed
> configuration so defining it in pci_regs.h.

> +#include <linux/of_irq.h>

> +#include <linux/of_platform.h>

I hardly see the use of above...

> + if (device_property_read_u32(dev, "reset-assert-ms", &lpp->rst_intrvl))
> + lpp->rst_intrvl = RESET_INTERVAL_MS;

...perhaps you need to add

#include <linux/property.h>

instead.

--
With Best Regards,
Andy Shevchenko