Re: [PATCH] regulator: rn5t618: fix rc5t619 ldo10 enable

Mark Brown
2019-11-14T11:54:38Z

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

On Wed, Nov 13, 2019 at 08:26:33PM +0100, Andreas Kemnade wrote:
> Mark Brown <broonie@kernel.org> wrote:

> > This definitely looks like a bug but without a datasheet or testing it's
> > worrying guessing at the register bit to use for the enable for the
> > second LDO...

> I am hoping for a Tested-By: from the one who has submitted the patch
> for the regulator.

Or a reviewed-by from someone with access to the datasheet.

> Well, it is not just guessing, it is there in the url I referenced. But
> I would of course prefer a better source. At first I wanted to spread
> my findings.

The URL you provided looked to be for a different part though?

> I am not pushing anyone to accept it without Tested-By/Reviewed-Bys.
> What is a good way to avoid people bumping into this bug?
> Maybe I can find the right C on the board to check.

That'd be good. Or we could fix it by just removing enable/disable
control for the second LDO entirely and if someone needs that control
they can always re-add it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]