From: kbuild test robot <lkp@intel.com>
To: Jon Flatley <jflat@chromium.org>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
bleung@chromium.org, groeck@chromium.org, sre@kernel.org,
jflat@chromium.org
Subject: Re: [PATCH 3/3] platform: chrome: Added cros-ec-typec driver
Date: Wed, 13 Nov 2019 20:55:44 +0800 [thread overview]
Message-ID: <201911132033.3UoCbltt%lkp@intel.com> (raw)
In-Reply-To: <20191113031044.136232-4-jflat@chromium.org>
Hi Jon,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on ljones-mfd/for-mfd-next]
[cannot apply to v5.4-rc7 next-20191113]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Jon-Flatley/ChromeOS-EC-USB-C-Connector-Class/20191113-193504
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/platform/chrome/cros_ec_typec.c:223:9-16: ERROR: PTR_ERR applied after initialization to constant on line 222
vim +223 drivers/platform/chrome/cros_ec_typec.c
206
207 static int cros_typec_add_partner(struct typec_data *typec, int port_num,
208 bool pd_enabled)
209 {
210 struct port_data *port;
211 struct typec_partner_desc p_desc;
212 int ret;
213
214 port = typec->ports[port_num];
215 p_desc.usb_pd = pd_enabled;
216 p_desc.identity = &port->p_identity;
217
218 port->partner = typec_register_partner(port->port, &p_desc);
219 if (IS_ERR_OR_NULL(port->partner)) {
220 dev_err(typec->dev, "Port %d partner register failed\n",
221 port_num);
> 222 port->partner = NULL;
> 223 return PTR_ERR(port->partner);
224 }
225
226 ret = cros_typec_query_pd_info(typec, port_num);
227 if (ret < 0) {
228 dev_err(typec->dev, "Port %d PD query failed\n", port_num);
229 typec_unregister_partner(port->partner);
230 port->partner = NULL;
231 return ret;
232 }
233
234 ret = typec_partner_set_identity(port->partner);
235 return ret;
236 }
237
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
next prev parent reply other threads:[~2019-11-13 12:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 3:10 [PATCH 0/3] ChromeOS EC USB-C Connector Class Jon Flatley
2019-11-13 3:10 ` [PATCH 1/3] platform: chrome: Add cros-ec-usbpd-notify driver Jon Flatley
2019-11-14 21:43 ` Enric Balletbo Serra
2019-11-13 3:10 ` [PATCH 2/3] power: supply: cros-ec-usbpd-charger: Fix host events Jon Flatley
2019-11-14 21:53 ` Enric Balletbo Serra
2019-11-13 3:10 ` [PATCH 3/3] platform: chrome: Added cros-ec-typec driver Jon Flatley
2019-11-13 12:55 ` kbuild test robot [this message]
2019-11-13 17:23 ` Jon Flatley
2019-11-14 0:55 ` [kbuild-all] " Rong Chen
2019-11-14 1:07 ` Guenter Roeck
2019-11-14 16:53 ` Heikki Krogerus
2019-11-13 17:51 ` [PATCH 0/3] ChromeOS EC USB-C Connector Class Benson Leung
2019-11-13 18:25 ` Heikki Krogerus
2019-11-14 1:09 ` Jon Flatley
2019-11-14 15:24 ` Heikki Krogerus
2019-11-14 21:00 ` Jon Flatley
2019-11-15 16:41 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911132033.3UoCbltt%lkp@intel.com \
--to=lkp@intel.com \
--cc=bleung@chromium.org \
--cc=groeck@chromium.org \
--cc=jflat@chromium.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox