public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Javier F. Arias" <jarias.linux@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: Fix CamelCase in function names
Date: Thu, 14 Nov 2019 05:46:55 +0800	[thread overview]
Message-ID: <20191113214655.GB3926041@kroah.com> (raw)
In-Reply-To: <20191113174348.oxek47hs7rxruisr@gmail.com>

On Wed, Nov 13, 2019 at 12:43:48PM -0500, Javier F. Arias wrote:
> This patch fixes CamelCase in function names with the ffs prefix.
> Issue found by checkpatch.
> 
> Signed-off-by: Javier F. Arias <jarias.linux@gmail.com>
> ---
>  drivers/staging/exfat/exfat_super.c | 84 ++++++++++++++---------------
>  1 file changed, 42 insertions(+), 42 deletions(-)
> 
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 23002aefc964..a6bbf0d7d378 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -343,7 +343,7 @@ static inline void exfat_save_attr(struct inode *inode, u32 attr)
>  		EXFAT_I(inode)->fid.attr = attr & (ATTR_RWMASK | ATTR_READONLY);
>  }
>  
> -static int ffsMountVol(struct super_block *sb)
> +static int ffs_mount_vol(struct super_block *sb)

Can't you just get rid of the crazy ffs prefix as well?

That would be best, look at the TODO file, it says to do just that :)

thanks,

greg k-h

      reply	other threads:[~2019-11-13 21:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 17:43 [PATCH] staging: exfat: Fix CamelCase in function names Javier F. Arias
2019-11-13 21:46 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113214655.GB3926041@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jarias.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox