From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7086BC43215 for ; Wed, 13 Nov 2019 23:00:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 468FC206E3 for ; Wed, 13 Nov 2019 23:00:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573686012; bh=2AmqOHyJ6omnuRzB5myDDOYWpOkM5LXqNgKm+BcO0DM=; h=In-Reply-To:References:Cc:To:From:Subject:Date:List-ID:From; b=ncPyJRHfdw6f2AdIjIyQPVwCElL/Ca8NUvE4r/H2TlwUXBaBvkHmTCDECUTjcOfxM 0fQToppYQKVZ0rOkMaFxvnWR9YXongsQjlAPNejZ4x31IK8lydQZpQSsQDm/il2ZKi K4XKYE4DAoHSzRRbABOtopPvMjUiKIhgwUTfXCJs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbfKMXAK (ORCPT ); Wed, 13 Nov 2019 18:00:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:60430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726564AbfKMXAK (ORCPT ); Wed, 13 Nov 2019 18:00:10 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6731F206E3; Wed, 13 Nov 2019 23:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573686010; bh=2AmqOHyJ6omnuRzB5myDDOYWpOkM5LXqNgKm+BcO0DM=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=U1OmHvn7yTe0q9tomleg7XpTyaB1EQTLSdnzts5zIBElzVfeyiW+/o/qhv4pW0fkc NnFu6UYR1dbfJ+fcXe6QuRRHfjxPuOcqhYm64O/BP68yIoGBcbu7Maq0YsI8jxMqJI I8lE+eA4bbW2BC0nzBURe2C42Adq3gUOO+YiLgpc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1995139bee5248ff3e9d46dc715968f212cfc4cc.1570520268.git.baolin.wang@linaro.org> References: <1995139bee5248ff3e9d46dc715968f212cfc4cc.1570520268.git.baolin.wang@linaro.org> Cc: orsonzhai@gmail.com, baolin.wang@linaro.org, zhang.lyra@gmail.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Baolin Wang , mturquette@baylibre.com From: Stephen Boyd Subject: Re: [PATCH v2 1/2] clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle() User-Agent: alot/0.8.1 Date: Wed, 13 Nov 2019 15:00:08 -0800 Message-Id: <20191113230010.6731F206E3@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Baolin Wang (2019-10-08 00:41:38) > The syscon_regmap_lookup_by_phandle() will never return NULL, thus use > IS_ERR() to validate the return value instead of IS_ERR_OR_NULL(). >=20 > Fixes: d41f59fd92f2 ("clk: sprd: Add common infrastructure") > Signed-off-by: Baolin Wang > --- Applied to clk-next