From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Hewenliang <hewenliang4@huawei.com>,
tstoyanov@vmware.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org, linfeilong@huawei.com
Subject: Re: [PATCH] tools lib traceevent: Fix memory leakage in copy_filter_type
Date: Wed, 13 Nov 2019 21:01:49 -0200 [thread overview]
Message-ID: <20191113230149.GA8999@redhat.com> (raw)
In-Reply-To: <20191113154044.5b591bf8@gandalf.local.home>
Em Wed, Nov 13, 2019 at 03:40:44PM -0500, Steven Rostedt escreveu:
> On Wed, 13 Nov 2019 18:37:10 -0200
> Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
>
> > Em Wed, Nov 13, 2019 at 02:46:26PM -0500, Steven Rostedt escreveu:
> > > On Fri, 25 Oct 2019 04:23:12 -0400
> > > Hewenliang <hewenliang4@huawei.com> wrote:
> > >
> > > > It is necessary to free the memory that we have allocated
> > > > when error occurs.
> > > >
> > > > Fixes: ef3072cd1d5c ("tools lib traceevent: Get rid of die in add_filter_type()")
> > > > Signed-off-by: Hewenliang <hewenliang4@huawei.com>
> > >
> > > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > >
> > > Arnaldo,
> >
> > sure
>
> I found an issue with it (if you didn't see the next email).
>
> Please don't take it.
ok.
> Thanks!
>
> -- Steve
>
> >
> > > Can you take this?
> > >
> > > -- Steve
> >
next prev parent reply other threads:[~2019-11-13 23:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 8:23 [PATCH] tools lib traceevent: Fix memory leakage in copy_filter_type Hewenliang
2019-11-13 19:46 ` Steven Rostedt
2019-11-13 19:47 ` Steven Rostedt
2019-11-13 20:37 ` Arnaldo Carvalho de Melo
2019-11-13 20:40 ` Steven Rostedt
2019-11-13 23:01 ` Arnaldo Carvalho de Melo [this message]
2019-11-18 3:42 ` Hewenliang
2019-11-19 1:44 ` [PATCH v2] " Hewenliang
2019-11-21 14:43 ` Arnaldo Carvalho de Melo
2019-11-23 8:15 ` [tip: perf/core] libtraceevent: " tip-bot2 for Hewenliang
2019-11-18 14:28 ` [PATCH v2] tools lib traceevent: " Steven Rostedt
2019-11-18 15:24 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113230149.GA8999@redhat.com \
--to=acme@redhat.com \
--cc=hewenliang4@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tstoyanov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox