Re: [PATCH] tty: serial: samsung: rename to fix build warning

Sudip Mukherjee
2019-11-11T15:19:17Z

Hi Greg,

On Mon, Nov 4, 2019 at 4:43 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Oct 18, 2019 at 08:47:07PM +0100, Sudip Mukherjee wrote:
> > The build of arm allmodconfig gives a warning:
> >
> > warning: same module names found:
> > drivers/tty/serial/samsung.ko
> > drivers/mtd/nand/onenand/samsung.ko
> >
> > Rename drivers/tty/serial/samsung.c to drivers/tty/serial/samsung_tty.c
> > to fix the warning.
> >
<snip>
>
>
> What are you going to break if you rename this module?

hopefully nothing.

>
> What configs enable both of these other than allmodconfig? Why rename
> the tty driver and not the mtd driver? Why not both?

But, there is no other config defined which has both enabled. Though I can
make one, but since it is not defined and no one else has reported this, I think
its better if you discard this. ( I think you already have :) ) or if
you want I can
send a v2 renaming both.

--
Regards
Sudip