Re: [PATCH] tty: serial: samsung: rename to fix build warning

Greg Kroah-Hartman
2019-11-04T16:43:57Z

On Fri, Oct 18, 2019 at 08:47:07PM +0100, Sudip Mukherjee wrote:
> The build of arm allmodconfig gives a warning:
>
> warning: same module names found:
> drivers/tty/serial/samsung.ko
> drivers/mtd/nand/onenand/samsung.ko
>
> Rename drivers/tty/serial/samsung.c to drivers/tty/serial/samsung_tty.c
> to fix the warning.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> drivers/tty/serial/Makefile | 2 +-
> drivers/tty/serial/{samsung.c => samsung_tty.c} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename drivers/tty/serial/{samsung.c => samsung_tty.c} (100%)
>
> diff --git a/drivers/tty/serial/Makefile b/drivers/tty/serial/Makefile
> index 863f47056539..d056ee6cca33 100644
> --- a/drivers/tty/serial/Makefile
> +++ b/drivers/tty/serial/Makefile
> @@ -30,7 +30,7 @@ obj-$(CONFIG_SERIAL_PXA_NON8250) += pxa.o
> obj-$(CONFIG_SERIAL_PNX8XXX) += pnx8xxx_uart.o
> obj-$(CONFIG_SERIAL_SA1100) += sa1100.o
> obj-$(CONFIG_SERIAL_BCM63XX) += bcm63xx_uart.o
> -obj-$(CONFIG_SERIAL_SAMSUNG) += samsung.o
> +obj-$(CONFIG_SERIAL_SAMSUNG) += samsung_tty.o
> obj-$(CONFIG_SERIAL_MAX3100) += max3100.o
> obj-$(CONFIG_SERIAL_MAX310X) += max310x.o
> obj-$(CONFIG_SERIAL_IP22_ZILOG) += ip22zilog.o
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung_tty.c
> similarity index 100%
> rename from drivers/tty/serial/samsung.c
> rename to drivers/tty/serial/samsung_tty.c
> --
> 2.11.0
>

What are you going to break if you rename this module?

What configs enable both of these other than allmodconfig? Why rename
the tty driver and not the mtd driver? Why not both?

thanks,

greg k-h