From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B68C43141 for ; Fri, 15 Nov 2019 06:21:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 927892073C for ; Fri, 15 Nov 2019 06:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573798870; bh=Zy1uBYvPG6qBGTDoOPyw2yrFYen+93X9hti5Uk74Mfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wT96B3AuENOBcOkTA8ZOJQ0OLUnpkgDH11JbiGx6sKqybA+VB116HUQfAe5uqQxI/ tb+U+IJppXKvA5PkA8flM1ke/x56sddZ5RinjIizAhX1fyuTVzyNFfkwe8OVmNzJ3c D597+cYxIgNQGOVGsxvE2JceDn2eZ8h2wufF8be4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726996AbfKOGVJ (ORCPT ); Fri, 15 Nov 2019 01:21:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:49774 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfKOGVJ (ORCPT ); Fri, 15 Nov 2019 01:21:09 -0500 Received: from localhost (unknown [104.132.150.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 53D1A2073A; Fri, 15 Nov 2019 06:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573798868; bh=Zy1uBYvPG6qBGTDoOPyw2yrFYen+93X9hti5Uk74Mfw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cEbHH4CvuPiWde+xDfiJ+NU42Z6NEyd+Fhzt69JLrGVoTpdtXr7qNAGWX0uM3fVlk 7WQ+FqlVM/rSdtsIFES8jPt9wsP4coqy05pCGK31qxCum1qKORJK4CroIKJylVL4LC 7aZ698SMiayWpIPRYi0IZOwv4LV3iah7W6+uuFsY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Junaid Shahid , Paolo Bonzini , Sean Christopherson , Sasha Levin Subject: [PATCH 4.4 01/20] kvm: mmu: Dont read PDPTEs when paging is not enabled Date: Fri, 15 Nov 2019 14:20:30 +0800 Message-Id: <20191115062008.017263210@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191115062006.854443935@linuxfoundation.org> References: <20191115062006.854443935@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Junaid Shahid [ Upstream commit d35b34a9a70edae7ef923f100e51b8b5ae9fe899 ] kvm should not attempt to read guest PDPTEs when CR0.PG = 0 and CR4.PAE = 1. Signed-off-by: Junaid Shahid Signed-off-by: Paolo Bonzini Signed-off-by: Sean Christopherson Signed-off-by: Sasha Levin --- arch/x86/kvm/x86.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -575,7 +575,7 @@ static bool pdptrs_changed(struct kvm_vc gfn_t gfn; int r; - if (is_long_mode(vcpu) || !is_pae(vcpu)) + if (is_long_mode(vcpu) || !is_pae(vcpu) || !is_paging(vcpu)) return false; if (!test_bit(VCPU_EXREG_PDPTR, @@ -7168,7 +7168,7 @@ int kvm_arch_vcpu_ioctl_set_sregs(struct kvm_update_cpuid(vcpu); idx = srcu_read_lock(&vcpu->kvm->srcu); - if (!is_long_mode(vcpu) && is_pae(vcpu)) { + if (!is_long_mode(vcpu) && is_pae(vcpu) && is_paging(vcpu)) { load_pdptrs(vcpu, vcpu->arch.walk_mmu, kvm_read_cr3(vcpu)); mmu_reset_needed = 1; }