From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] mfd: syscon: Switch to use devm_ioremap_resource()
Date: Fri, 15 Nov 2019 12:20:51 +0200 [thread overview]
Message-ID: <20191115102051.GP32742@smile.fi.intel.com> (raw)
In-Reply-To: <CAK8P3a2D1eks7dirbX=LrdQy6w0HeA7-x8jb1=qkxfatPuc51w@mail.gmail.com>
On Fri, Nov 15, 2019 at 10:12:57AM +0100, Arnd Bergmann wrote:
> On Fri, Nov 15, 2019 at 9:49 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Instead of checking resource pointer for being NULL and
> > report some not very standard error codes in this case,
> > switch to devm_ioremap_resource() API.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> IIRC there are some slightly odd uses of syscon that rely on on us not calling
> devm_request_mem_region here, which is implied by devm_ioremap_resource()
> but not devm_ioremap().
Ah, I see.
> A patch to add a comment about this might be helpful though.
I think the comment won't help if there are overlapping regions are in use.
Probably no need to apply this for now.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-11-15 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 8:49 [PATCH v1 1/2] mfd: syscon: Re-use resource_size() to count max_register Andy Shevchenko
2019-11-15 8:49 ` [PATCH v1 2/2] mfd: syscon: Switch to use devm_ioremap_resource() Andy Shevchenko
2019-11-15 9:12 ` Arnd Bergmann
2019-11-15 10:20 ` Andy Shevchenko [this message]
2019-11-15 9:10 ` [PATCH v1 1/2] mfd: syscon: Re-use resource_size() to count max_register Arnd Bergmann
2019-12-09 8:45 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115102051.GP32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox